Skip to content

Addressable scene loading #3040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 241 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
241 commits
Select commit Hold shift + click to select a range
e36996c
update
NoelStephensUnity Mar 25, 2024
67f4a62
update
NoelStephensUnity Mar 25, 2024
41d13bc
update
NoelStephensUnity Mar 25, 2024
20d1cc1
update
NoelStephensUnity Mar 25, 2024
552a37c
update
NoelStephensUnity Mar 25, 2024
bcbbb61
update and style
NoelStephensUnity Mar 25, 2024
1fda8ee
update
NoelStephensUnity Mar 25, 2024
e030a59
update
NoelStephensUnity Mar 25, 2024
8a9a852
Update package.json
NoelStephensUnity Mar 25, 2024
e322544
Update ValidationExceptions.json
NoelStephensUnity Mar 25, 2024
a1c5d1d
update
NoelStephensUnity Mar 25, 2024
43bc25d
update
NoelStephensUnity Mar 26, 2024
18b389d
test fix
NoelStephensUnity Mar 26, 2024
41dd028
fix
NoelStephensUnity Mar 26, 2024
a2ccf77
Update CHANGELOG.md
NoelStephensUnity Mar 26, 2024
0e04678
test fix
NoelStephensUnity Mar 26, 2024
a3b503b
update
NoelStephensUnity Mar 26, 2024
6953178
Merge branch 'experimental/distributed-authority' into experimental/d…
NoelStephensUnity Mar 26, 2024
54ed8bf
update
NoelStephensUnity Mar 26, 2024
3569d80
fix
NoelStephensUnity Mar 26, 2024
65c0cd6
style
NoelStephensUnity Mar 26, 2024
916e637
style
NoelStephensUnity Mar 26, 2024
5d38c54
style
NoelStephensUnity Mar 26, 2024
c9df98b
test
NoelStephensUnity Mar 26, 2024
6132bb9
test
NoelStephensUnity Mar 26, 2024
959e887
style
NoelStephensUnity Mar 26, 2024
dbcb347
update
NoelStephensUnity Mar 27, 2024
ee27047
update & fix
NoelStephensUnity Mar 29, 2024
400cdc0
test fix
NoelStephensUnity Mar 30, 2024
5877aad
test and style
NoelStephensUnity Mar 30, 2024
beebcd6
test fix
NoelStephensUnity Mar 30, 2024
38fe8c2
test fix
NoelStephensUnity Mar 31, 2024
65d9742
style
NoelStephensUnity Mar 31, 2024
ba9f37a
test
NoelStephensUnity Mar 31, 2024
77ae80a
test
NoelStephensUnity Mar 31, 2024
7904e3d
fix & test
NoelStephensUnity Mar 31, 2024
2aa38ce
update
NoelStephensUnity Mar 31, 2024
a038711
update
NoelStephensUnity Apr 1, 2024
bcf94a7
fix
NoelStephensUnity Apr 1, 2024
81a88fc
update
NoelStephensUnity Apr 1, 2024
bbdcf59
update & fix
NoelStephensUnity Apr 1, 2024
0f34139
test fix
NoelStephensUnity Apr 1, 2024
e7ac3c8
chore: update to for Unity6 support (#2863)
NoelStephensUnity Apr 3, 2024
b0106c3
chore
NoelStephensUnity Apr 25, 2024
b449ea8
fix: in-scene networkobject with networktransform synchronization whe…
NoelStephensUnity Apr 25, 2024
db2315c
fix
NoelStephensUnity Apr 26, 2024
be8a02a
feat: add pre and post spawn methods [MTT-8470] up-port v2.0.0 (#2912)
NoelStephensUnity May 2, 2024
f6f815c
chore!: migrate components to runtime assembly [MTT-8472] (#2914)
NoelStephensUnity May 10, 2024
0e10948
chore: add second part of session restore (#2919)
NoelStephensUnity May 10, 2024
4e35f84
fix: In-scene placed NetworkObjects getting destroyed if early discon…
NoelStephensUnity May 14, 2024
6a4bb8f
feat: enum ordered message versioning (#2929)
NoelStephensUnity May 21, 2024
0060d33
chore: migrate tests from public to internal (#2930)
fluong6 May 22, 2024
3f59dff
chore: NGO 2.0.0-exp.4 merge back to develop NGO 2.0.0 (#2940)
fluong6 May 31, 2024
98d4bbc
fix: new message versioning starting after session owner message (#2942)
NoelStephensUnity Jun 3, 2024
25c7e6b
refactor: Ensure lengths are always written as uints (#2946)
EmandM Jun 5, 2024
d9e1a5c
chore: merge release 2.0.0-exp.5 into develop-2.0.0 (#2947)
NoelStephensUnity Jun 10, 2024
60d321d
chore: Break up the NetworkVariableSerialization file (#2950)
EmandM Jun 13, 2024
90cbb1e
fix: ownership change halfprecision, session owner onclientconnected,…
NoelStephensUnity Jun 15, 2024
2493ff6
fix
NoelStephensUnity Jun 16, 2024
59cdd30
fix: MPSNGM-302 Fix DA integration tests (#2955)
EmandM Jun 18, 2024
8b13c4e
chore: merge 2.0.0 pre.2 into develop 2.0.0 (#2965)
NoelStephensUnity Jun 26, 2024
5bff58f
fix: post 2.0.0-pre.2 fixes and updates (#2962)
NoelStephensUnity Jun 26, 2024
8f71c14
update
NoelStephensUnity Jul 1, 2024
d4a6dcc
fix: InstantiateAndSpawn not honoring ownerClientId parameter in clie…
NoelStephensUnity Jul 15, 2024
ee0e045
fix
NoelStephensUnity Jul 16, 2024
558fc67
fix: scenemanager clean up ScenesLoaded after synch unloading of rema…
NoelStephensUnity Jul 16, 2024
d70f417
feat: MPSNGM-294 patch DA network variables (#2958)
EmandM Jul 17, 2024
5b93ce6
chore: protected network manager (#2975)
DSchroer Jul 18, 2024
7ea9f9d
fix: Regression between comb-server and NGO network variables (#2974)
EmandM Jul 18, 2024
9c927df
fix: Fixing API doc issues (#2976)
jabbacakes Jul 18, 2024
af564b6
chore: merge v2.0.0-pre.3 into develop-2.0.0 (#2991)
NoelStephensUnity Jul 29, 2024
9ef01ba
fix: Improve API doc for OnGainedOwnership and OnLostOwnership (#2997)
jabbacakes Aug 5, 2024
04825ac
feat: add ping tool to public repo (#3001)
NoelStephensUnity Aug 5, 2024
29e5146
update
NoelStephensUnity Aug 6, 2024
0c9ac4e
fix: notauthority da mode urpc sending to self (#3000)
NoelStephensUnity Aug 6, 2024
d2bc5d4
fix: MPSNGM-365 Remove invalid ProxyMessage test (#3006)
EmandM Aug 12, 2024
133c125
fix: collections not detecting deltas (#3004)
NoelStephensUnity Aug 13, 2024
57797b7
fix: fixedstring byte writing and comparing up port (#3009)
NoelStephensUnity Aug 13, 2024
503dd15
fix: dual triggers generating false state transition up port (#3008)
NoelStephensUnity Aug 13, 2024
285e307
fix: adding null checks when accessing NetworkBehaviour for develop 2…
fluong6 Aug 19, 2024
977746d
fix: nested networktransforms not updating (#3016)
NoelStephensUnity Aug 20, 2024
99dc876
fix: networkanimator auto owner authoritative mode when in distribute…
NoelStephensUnity Aug 21, 2024
1b900a4
chore: NGO 2.0.0-pre.4 merge back to develop NGO develop 2.0.0 (#3025)
fluong6 Aug 23, 2024
61a2d0d
fix: Stop checking hierarchy changed in playmode (#3026)
NoelStephensUnity Aug 26, 2024
40f84dc
fix: prevent exception when showing despawned NetworkObject - up port…
NoelStephensUnity Aug 26, 2024
2fd4114
Local changes for addressable support
kroecks May 10, 2024
36625fa
pending update
kroecks May 10, 2024
8d7b51b
local trollking changes
kroecks May 10, 2024
640a7a3
minor change
kroecks Jun 8, 2024
21cf55e
fix: allow the check for a NetworkObject component on NetworkBehaviou…
NoelStephensUnity Aug 31, 2024
aee018c
fix: NetworkTransform initial synchronization, parenting, smooth tran…
NoelStephensUnity Sep 5, 2024
c0cd658
fix: player prefab null exception when using prefab hash via connecti…
NoelStephensUnity Sep 6, 2024
8e62d9e
fix: Add size validation to named and unnamed message sending [Up Por…
NoelStephensUnity Sep 7, 2024
91bb80e
fix: hidden objects from newly promoted session owner still synchroni…
NoelStephensUnity Sep 7, 2024
4b58d28
fix: NetworkVariable LastUpdateSent client timing (#3045)
NoelStephensUnity Sep 8, 2024
26c01ec
chore: example Non-Rigidbody CharacterController, moving bodies, smo…
NoelStephensUnity Sep 9, 2024
7389f8b
fix: networkshow client connected scenemanagement disabled (#3056)
NoelStephensUnity Sep 9, 2024
1d22804
chore: final 2.0.0 clean up tasks (#3052)
NoelStephensUnity Sep 9, 2024
31c30e5
fix: networkanimator only updates observers (#3057)
NoelStephensUnity Sep 10, 2024
da4649e
chore: NGO 2.0.0 merge back to develop NGO develop 2.0.0 (#3068)
fluong6 Sep 17, 2024
3afc6f9
fix: spawn many objects apv failures (#3069)
NoelStephensUnity Sep 17, 2024
ef9e1c1
fix: client side disconnect incorrect client count on host-server sid…
NoelStephensUnity Sep 25, 2024
390c332
fix: player spawn not applying position and rotation via connection a…
NoelStephensUnity Sep 27, 2024
cb7ec98
fix: player prefab spawning not honoring when spawnwithobservers is d…
NoelStephensUnity Sep 27, 2024
87d23e9
fix: NetworkManager instantiate & destroy notifications and player sp…
NoelStephensUnity Oct 8, 2024
0bef65c
chore: updates to comb-server bypass and connection sequence configur…
NoelStephensUnity Oct 10, 2024
058481b
fix: in-sceneobject NetworkObject update in editor tool (up-port) (#3…
NoelStephensUnity Oct 10, 2024
0055e1c
fix: provide non Rigidbody contact events and Rigidbody prioritizatio…
NoelStephensUnity Oct 11, 2024
e9b7ef4
fix: scene loading event not synchronizing in scene objects (#3096)
NoelStephensUnity Oct 11, 2024
5f7441c
chore: adjust ConnectionRequestMessage to use ClientConfig version as…
NoelStephensUnity Oct 14, 2024
3625247
fix: client-server owner authoritative nested NetworkTransform invali…
NoelStephensUnity Oct 14, 2024
6b459a1
fix: minor fixes for 2.1.0 (#3097)
NoelStephensUnity Oct 15, 2024
632bf35
fix: networkvariable collections can be modified without write permis…
NoelStephensUnity Oct 16, 2024
9509696
fix: prefab processor dirty up port (up port) (#3103)
NoelStephensUnity Oct 17, 2024
c2ab328
chore: NGO 2.1.0 merge back to develop NGO develop 2.0.0 (#3104)
fluong6 Oct 18, 2024
264b30d
bump version to 2.1.1
fluong6 Oct 18, 2024
5378d4d
fix: ping tool example updates and fixes (#3106)
NoelStephensUnity Oct 18, 2024
a0f1165
chore: NGO 2.1.1 merge back to develop NGO develop 2.0.0 (#3105)
fluong6 Oct 21, 2024
a115c83
fix: NetworkAnimator parameter writebuffer limits causes exception (#…
NoelStephensUnity Oct 21, 2024
c696b58
fix: Distributed Authority codec tests not using message version (#3109)
NoelStephensUnity Oct 22, 2024
b64117e
fix: Player removed from observers when player object despawns (#3110)
NoelStephensUnity Oct 24, 2024
7f639ff
Merge branch 'Unity-Technologies:develop' into addressable
kroecks Oct 31, 2024
bebd5a5
Merge remote-tracking branch 'origin/2.1.1' into addressables
kroecks Oct 31, 2024
d709df4
fix: send to not owner server warning message (#3111)
NoelStephensUnity Nov 4, 2024
8e494c4
upgrade changes
kroecks Nov 6, 2024
789f375
fix: NetworkTransport early and post late updates (#3113)
NoelStephensUnity Nov 6, 2024
edc8b78
fix: Hide Debug Simulator for NGO 2.0+ (#3121)
simon-lemay-unity Nov 12, 2024
d218b29
fix: alternate player spawning no players or networkclient player reg…
NoelStephensUnity Nov 12, 2024
5d97c45
fix: in-sceneobject networkobject update in editor tool update (up-po…
NoelStephensUnity Nov 15, 2024
72e4f20
fix: NetworkVariable dispose original internal (#3128)
NoelStephensUnity Nov 18, 2024
90f97fd
fix: provide users ability to get client endpoint (#3130)
NoelStephensUnity Nov 19, 2024
487e469
feat: server distribution config (#3132)
DSchroer Nov 20, 2024
1845a33
fix: synchronizing connected clients additively loaded scenes only wh…
NoelStephensUnity Nov 22, 2024
86ddd7d
chore: object synchronization distributed authority mode when scene m…
NoelStephensUnity Nov 23, 2024
2b0a9b2
fix: Server only session issues with parent synchronize and networkob…
NoelStephensUnity Nov 24, 2024
17f7f25
fix: ObjectDisposedException on NetworkManager after shutting down th…
EmandM Nov 26, 2024
dfabbed
chore: refactor session version serialization and configuration (#3138)
NoelStephensUnity Dec 2, 2024
d7df73b
fix: networklist editor memory leak (#3147)
NoelStephensUnity Dec 3, 2024
218a647
fix: make ClientConfig version signed (#3150)
DSchroer Dec 3, 2024
3c4f1cc
feat: Remove DA NetworkVariable modifications (#3155)
EmandM Dec 6, 2024
f170341
chore: api documentation phase 1 (#3156)
NoelStephensUnity Dec 7, 2024
88eaa08
fix: distributed authority spawning prefab overrides (#3160)
NoelStephensUnity Dec 9, 2024
5e38c31
fix: prefab incontext or inIsolation edit mode globalobjectidhash inc…
NoelStephensUnity Dec 10, 2024
c69aa97
chore: forward port of Wrench from release/1.12.0 branch (#3171)
michalChrobot Dec 12, 2024
b7ee6ef
update
NoelStephensUnity Dec 12, 2024
4a77fb2
update
NoelStephensUnity Dec 12, 2024
088755e
update
NoelStephensUnity Dec 12, 2024
004a220
fix
NoelStephensUnity Dec 12, 2024
64195d5
style
NoelStephensUnity Dec 12, 2024
1914d3c
style
NoelStephensUnity Dec 12, 2024
658ef01
style
NoelStephensUnity Dec 12, 2024
2b3893c
fix: clamp spawntimeout to recommended range (#3174)
NoelStephensUnity Dec 12, 2024
2d10975
feat: Add a SessionOwner ObjectStatus and allow InScenePlaced network…
EmandM Dec 13, 2024
6de550b
chore: merge develop 2 0 0 updates with SessionOwner permissions (#3176)
NoelStephensUnity Dec 13, 2024
1a2a627
chore: adding overriding scenes and prefabs example (#3161)
NoelStephensUnity Dec 14, 2024
c0e65f4
fix
NoelStephensUnity Dec 16, 2024
ba49065
fix: server, host, or session owner not populating in-scene placed ob…
NoelStephensUnity Dec 16, 2024
d7ef262
update
NoelStephensUnity Dec 16, 2024
628868a
Update
NoelStephensUnity Dec 16, 2024
ba35384
chore: merge release 2.2.0 back into develop-2.0.0 (#3179)
NoelStephensUnity Dec 16, 2024
53ec0e6
fix: client owned NetworkObject with prefabhandler destroy order inco…
NoelStephensUnity Jan 10, 2025
248aa21
chore: remove deprecated relay package (#3201)
NoelStephensUnity Jan 10, 2025
1249843
chore: update example overriding scenes networkprefabs dedicated serv…
NoelStephensUnity Jan 16, 2025
870452b
fix: more accurate local time sync with server time (up-port) (#3212)
NoelStephensUnity Jan 24, 2025
144bd78
fix: networkvariablebase not being reinitialized if networkobject per…
NoelStephensUnity Feb 3, 2025
b665499
fix: Unnecessary change ownership message (#3222)
EmandM Feb 4, 2025
2eee998
fix: NetworkObject.DeferDespawn not respecting DestroyGameObject para…
EmandM Feb 5, 2025
05c64fa
chore: remove unitytransport debug asserts [up-port] (#3226)
NoelStephensUnity Feb 5, 2025
6a4f718
ci: enabling renovate bot on develop-2.0.0 (#3191)
michalChrobot Feb 5, 2025
cd6fd5b
fix: Exception with disabled GameObjects and NetworkTransforms (#3243)
EmandM Feb 7, 2025
21b7023
chore: [Backport] Added Ci related folders to gitignore and updated W…
michalChrobot Feb 10, 2025
c369bfd
fix: distribute parented children distributing with root parent (#3203)
NoelStephensUnity Feb 10, 2025
be45e86
build: NGO CI update and rewrite [2.X] (#3193)
michalChrobot Feb 11, 2025
4ff5b8e
fix: nested NetworkTransforms with different authority settings (#3209)
NoelStephensUnity Feb 12, 2025
6c46dfd
fix: network objects to synchronize scene changes edge cases (#3230)
NoelStephensUnity Feb 12, 2025
ac03043
chore: [2.X] testprojects minimal editor update (#3285)
michalChrobot Feb 12, 2025
91ebe96
chore(deps): update dependency recipeengine.modules.wrench to 0.10.37…
unity-renovate[bot] Feb 13, 2025
191251d
docs: fixes of PVP-150-1 [2.X] (#3223)
michalChrobot Feb 14, 2025
f488652
chore: [2.X] Renovate updates integration (#3287)
michalChrobot Feb 14, 2025
069a926
chore: update code owners up port (#3294)
NoelStephensUnity Feb 14, 2025
711aa02
feat: Rework the DestroyObject path on the non-authority client (#3291)
EmandM Feb 14, 2025
7b239f2
feat: Optimize DestroyObject message (#3304)
EmandM Feb 19, 2025
9493824
fix: Incorrect clientId in OnClientConnectedCallback (#3312)
EmandM Feb 20, 2025
534f74e
fix: selecting everything selects session owner only (#3305)
NoelStephensUnity Feb 21, 2025
65cac82
chore(deps): update dependency recipeengine.modules.wrench to 0.10.38…
unity-renovate[bot] Feb 21, 2025
fc03f94
ci: [2.X] Turn off title validation for single commit PRs (#3314)
EmandM Feb 21, 2025
b47bc65
chore(deps): update dependency recipeengine.modules.wrench to 0.10.39…
unity-renovate[bot] Feb 23, 2025
6ecfcc1
chore(deps): update dependency recipeengine.modules.wrench to 0.10.40…
unity-renovate[bot] Feb 24, 2025
84c06c7
ci: [2.X] CI failures fixes (#3302)
michalChrobot Feb 24, 2025
e2ae8eb
ci: Added tracking information to ignored tests (#3308)
michalChrobot Feb 25, 2025
1ac59f0
fix: fastbufferreader does not honor arraysegment configuration (up p…
NoelStephensUnity Feb 25, 2025
096c22c
fix: AnticipatedNetworkVariable not updating previous value [MTTB-103…
NoelStephensUnity Feb 25, 2025
ca52b6c
chore(deps): update dependency recipeengine.modules.wrench to 0.10.41…
unity-renovate[bot] Feb 27, 2025
063606a
chore(deps): update dependency recipeengine.modules.wrench to 0.10.42…
unity-renovate[bot] Feb 28, 2025
dc13db4
chore(deps): update dependency recipeengine.modules.wrench to 0.10.43…
unity-renovate[bot] Mar 4, 2025
0e475bc
fix: Never distribute an object to a client who is not an observer (#…
EmandM Mar 6, 2025
be34997
fix: Block websocket use in dedicated server builds (#3336)
EmandM Mar 7, 2025
a49e1b8
Merge branch 'two' into clean
kroecks Mar 9, 2025
aa6f559
fixes
kroecks Mar 9, 2025
fd19d67
chore(deps): update dependency recipeengine.modules.wrench to 0.10.44…
unity-renovate[bot] Mar 10, 2025
e0da299
chore: Update the port of the codec tests (#3341)
EmandM Mar 10, 2025
429b256
fix: Objects without observers are DestroyWithOwner (#3342)
EmandM Mar 11, 2025
e5362a4
ci: [NGOv2.X] Fixing WhenAnticipating_ValueChangesImmediately test (#…
michalChrobot Mar 13, 2025
16c4409
fix: networktransform double lerp (MTTB-539) (#3337)
NoelStephensUnity Mar 14, 2025
fae6b2f
feat: add networkmanager topology analytics [MTT-9974] (#3309)
NoelStephensUnity Mar 14, 2025
8f2981b
fix: android time test failures due to edge case float precision erro…
NoelStephensUnity Mar 18, 2025
10d5843
docs: [NGOv2.X] Correction of API Reference link (#3353)
michalChrobot Mar 19, 2025
d79c743
ci: [NGOv2.X] Corrections of CI setup issues (#3329)
michalChrobot Mar 21, 2025
cab4d78
docs: [2.X] fixes of PVP exceptions (#3225)
michalChrobot Mar 24, 2025
d80340d
fix: distributed authority client synchronization issues (#3350)
NoelStephensUnity Mar 25, 2025
c754a2c
fix: owner changing ownership causing identical previous and current …
NoelStephensUnity Mar 25, 2025
e3189a2
refactor: Remove defines based on UTP version (#3362)
simon-lemay-unity Mar 26, 2025
120cdcc
fix: OnGainedOwnership and OnLostOwnership XML API updates (#3365)
NoelStephensUnity Mar 28, 2025
dfef393
fix: [NGOv2.x] Add OnPreShutdown to NetworkManager (#3366)
jonathanhertz Mar 29, 2025
2d36161
chore(deps): update dependency recipeengine.modules.wrench to 0.10.45…
unity-renovate[bot] Mar 31, 2025
7d4801f
ci: [2.X] disabling WebGL Build job on macOS due to "Light baking cou…
michalChrobot Mar 31, 2025
464e7cb
chore: [2.x] Add NetworkTransform parenting test (#3368)
EmandM Mar 31, 2025
0e1ae7e
chore: [2.X] Updated CODEOWNERS file (#3372)
michalChrobot Mar 31, 2025
cad4b4c
fix: buffered linear interpolator jitter and exposing more properties…
NoelStephensUnity Apr 3, 2025
bb0566c
fix: LegacyLerp was using ticklatency as opposed to legacy ticksAgo (…
NoelStephensUnity Apr 4, 2025
53b94ca
feat: session state token (#3228)
DSchroer Apr 7, 2025
78cad42
fix: Don't accept invalid connections in UnityTransport.Send (#3382)
simon-lemay-unity Apr 8, 2025
23412a0
refactor: Minor cleanups in Unity Transport (#3377)
simon-lemay-unity Apr 8, 2025
23eab5d
fix: In-Scene Placed Object Parenting, Serialization Order, and Trans…
NoelStephensUnity Apr 9, 2025
9329b80
ci: webgl build job timeout extended (#3389)
michalChrobot Apr 11, 2025
f3ec307
ci: backport-verification test (#3385)
michalChrobot Apr 11, 2025
dfadc33
chore: Updated support template to redirect users to Discord or Discu…
michalChrobot Apr 11, 2025
b041d76
chore: [Backport] GitHub actions mirrored from develop (#3394)
michalChrobot Apr 11, 2025
ece63de
Updated backport-verification test to rerun on commits
michalChrobot Apr 11, 2025
fe532aa
docs: [2.X] fixes of PVP exceptions (round 2) (#3375)
michalChrobot Apr 11, 2025
57c8cdd
chore(deps): update actions/checkout action to v4 (develop-2.0.0) (#3…
unity-renovate[bot] Apr 14, 2025
1402294
chore(deps): update actions/github-script action to v7 (develop-2.0.0…
unity-renovate[bot] Apr 14, 2025
e45e3b9
ci: Increased WebGL job timeout (#3399)
michalChrobot Apr 14, 2025
f6a6c1f
chore: merge 2.3.0 back to develop-2.0.0 (#3390)
NoelStephensUnity Apr 14, 2025
f2e776e
fix: instantiate, spawn, and parent when spawning (#3401)
NoelStephensUnity Apr 14, 2025
5267b2b
update
NoelStephensUnity Apr 14, 2025
bc46537
update
NoelStephensUnity Apr 14, 2025
524918e
Merge remote-tracking branch 'unity/release/2.3.1' into clean2
kroecks Apr 19, 2025
73c3a18
Merge updates
kroecks Apr 19, 2025
00744cd
logging
kroecks Apr 19, 2025
07b9508
add log
kroecks Apr 19, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
19 changes: 7 additions & 12 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,10 @@
# Order is important; the last matching pattern takes the most precedence.

* @Unity-Technologies/multiplayer-sdk
Profiling/ @Unity-Technologies/multiplayer-tools
Metrics/ @Unity-Technologies/multiplayer-tools
/com.unity.netcode.gameobjects/Runtime/Transports/ @Unity-Technologies/multiplayer-workflows
/com.unity.netcode.gameobjects/Tests/Editor/Transports/ @Unity-Technologies/multiplayer-workflows
/com.unity.netcode.gameobjects/Tests/Runtime/Transports/ @Unity-Technologies/multiplayer-workflows
*.asmdef @chrispope @miniwolf @NoelStephensUnity @fluong6
package.json @chrispope @miniwolf @NoelStephensUnity @fluong6
AssemblyInfo.cs @chrispope @miniwolf @NoelStephensUnity @fluong6
.editorconfig @chrispope @miniwolf @NoelStephensUnity @fluong6
.gitignore @chrispope @miniwolf @NoelStephensUnity @fluong6
.github/ @chrispope @miniwolf @NoelStephensUnity @fluong6
.yamato/ @chrispope @miniwolf @NoelStephensUnity @fluong6
*.asmdef @NoelStephensUnity @EmandM @Unity-Technologies/netcode-qa
package.json @NoelStephensUnity @EmandM @Unity-Technologies/netcode-qa
AssemblyInfo.cs @NoelStephensUnity @EmandM @Unity-Technologies/netcode-qa
.editorconfig @NoelStephensUnity @EmandM @Unity-Technologies/netcode-qa
.gitignore @NoelStephensUnity @EmandM @Unity-Technologies/netcode-qa
.github/ @NoelStephensUnity @EmandM @Unity-Technologies/netcode-qa
.yamato/ @NoelStephensUnity @EmandM @Unity-Technologies/netcode-qa
5 changes: 3 additions & 2 deletions .github/ISSUE_TEMPLATE/support.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ assignees: ''

---

Post your questions or problems here.
For support related questions we HIGHLY recommend to post a message either on the [Unity Discussions](https://discussions.unity.com/tag/netcode-for-gameobjects) or on our [Discord Community](https://discord.gg/TqNeJTtC) where you can get help from the community and the developers.
Those forums will get you the fastest response and are the best place to ask for help.

For general questions, networking advice or discussions about the Netcode for GameObjects, you can also reach us on our [Discord Community](https://discord.gg/FM8SE9E) or create a post in the [Unity Multiplayer Forum](https://forum.unity.com/forums/multiplayer.26/).
If you still feel like you want to open a support issue as an GitHub Issue, please make sure to include as much information as possible (also including any relevant code/project) to help us understand your problem.
12 changes: 10 additions & 2 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

<!-- Add short version of the JIRA ticket to the PR title (e.g. "feat: new shiny feature [MTT-123]") -->

<!-- Add RFC link here if applicable. -->

## Changelog

- Added: The package whose Changelog should be added to should be in the header. Delete the changelog section entirely if it's not needed.
Expand All @@ -26,3 +24,13 @@
- [ ] Deprecation of the API is explained in the CHANGELOG.
- [ ] The users can understand why this API was removed and what they should use instead.
-->

## Backport

<!-- If this is a backport:
- Add the following to the PR title: "\[Backport\] ..." .
- Link to the original PR.
If this needs a backport - state this here
If a backport is not needed please provide the reason why.
If the "Backports" section is not present it will lead to a CI test failure.
-->
37 changes: 37 additions & 0 deletions .github/renovate.json5
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
{
"baseBranches": ["develop", "develop-2.0.0"],
"dependencyDashboard": true,

"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": [
"local>Unity-Technologies/unity-renovate-config"
],
"prConcurrentLimit": 100,
// Ignore commits produced by GitHub actions workflows
"gitIgnoredAuthors": ["[email protected]"],
"ignorePaths": [
"**/node_modules/**",
// Don't renovate files in special folders using ~ as suffix
"**/*~/**",
"com.unity.netcode.gameobjects/**/*",
"Examples/**/*",
"testproject/**/*",
"minimalproject/**/*",
"testproject-tools-integration/**/*"
],
"packageRules": [
// Run unity-upm-project and unity-upm-package only on weekends to reduce PR noise
// Also ensure dependencies won't be downgraded when they don't exist in the public repositories
{
"matchManagers": [
"unity-upm-project",
"unity-upm-package"
],
"enabled": "true",
"schedule": [
"every weekend"
],
"rollbackPrs": false,
}
],
}
70 changes: 70 additions & 0 deletions .github/workflows/assignee-management.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
# This workflow manages issue assignments and related label changes:
# 1. When someone is assigned to an issue:
# - Removes "stat:awaiting-triage" label
# - Adds "stat:Investigating" label
# 2. When all assignees are removed from an issue:
# - Adds "stat:awaiting-triage" label
# - Removes "stat:Investigating" label
# 3. When "stat:Investigating" label is added:
# - Automatically assigns the issue to the person who added the label

name: Handle Issue Assignment and Labels

on:
issues:
types: [assigned, unassigned, labeled]

env:
AWAITING-TRIAGE_LABEL: stat:awaiting-triage
INVESTIGATING_LABEL: stat:Investigating

jobs:
handle_assignment:
name: Handle Issue Assignment Changes
if: ${{ !github.event.issue.pull_request && github.event.issue.state == 'open' }}
runs-on: ubuntu-latest
permissions:
issues: write

steps:
- name: Handle Assignment Changes
run: |
if [[ "${{ github.event.action }}" == "assigned" ]]; then
# Someone was assigned - remove awaiting-triage, add investigating
echo "ADD=${{ env.INVESTIGATING_LABEL }}" >> $GITHUB_ENV
echo "REMOVE=${{ env.AWAITING-TRIAGE_LABEL }}" >> $GITHUB_ENV
elif [[ "${{ github.event.action }}" == "unassigned" ]]; then
# Check if there are any remaining assignees
ASSIGNEES=$(echo '${{ toJson(github.event.issue.assignees) }}' | jq length)
if [[ "$ASSIGNEES" == "0" ]]; then
# No assignees left - add awaiting-triage, remove investigating
echo "ADD=${{ env.AWAITING-TRIAGE_LABEL }}" >> $GITHUB_ENV
echo "REMOVE=${{ env.INVESTIGATING_LABEL }}" >> $GITHUB_ENV
fi
fi

- name: Update Labels
if: env.ADD != '' || env.REMOVE != ''
run: gh issue edit "$NUMBER" --add-label "$ADD" --remove-label "$REMOVE"
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GH_REPO: ${{ github.repository }}
NUMBER: ${{ github.event.issue.number }}

handle_investigating_label:
name: Handle Investigating Label Addition
if: ${{ github.event.action == 'labeled' && github.event.label.name == 'stat:Investigating' && !github.event.issue.pull_request && github.event.issue.state == 'open' }}
runs-on: ubuntu-latest
permissions:
issues: write

steps:
- name: Assign Issue to person that added Investigating Label
run: |
# Assign the issue to the person who added the label
gh issue edit "$NUMBER" --add-assignee "$ACTOR"
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GH_REPO: ${{ github.repository }}
NUMBER: ${{ github.event.issue.number }}
ACTOR: ${{ github.actor }}
32 changes: 32 additions & 0 deletions .github/workflows/backport-verification.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# This workflow is designed to verify that the pull request description contains a "## Backport" section, which is important as a reminder to account for backports for anyone that works with NGO repository.
# We have 2 development branches (develop and develop-2.0.0) and we need to ensure that relevant changes are landing in only one or both of them
# If the "##Backport" section is missing, the workflow will fail and block the PR from merging, prompting the developer to add this section.

# The workflow is configured to run when PR is created as well as when it is edited which also counts simple description edits.

name: "NGO - Backport Verification"

on:
pull_request:
types: [opened, edited, synchronize, reopened]
branches:
- develop
- develop-2.0.0

jobs:
backport-verification:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4

- name: Check PR description
uses: actions/github-script@v7
with:
script: |
const pr = context.payload.pull_request;
const body = pr.body || '';

if (!body.includes('## Backport')) {
core.setFailed('PR description must include a "## Backport" section. Please add this section and provide information about this PR backport to develop or develop-2.0.0 branch respectively or explain why backport is not needed.');
}
6 changes: 3 additions & 3 deletions .github/workflows/conventional-pr.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Conventional PR

# Controls when the action will run.
# Controls when the action will run.
on:
pull_request:
branches:
Expand All @@ -17,7 +17,7 @@ jobs:
steps:
- name: semantic-pull-request
# Internal Unity mirror available at jesseo/action-semantic-pull-request, but actions from private repos aren't supported, so continue to use the public one below
uses: amannn/action-semantic-pull-request@b7a9a97cb10fa6e1ae02647e718798175f6b1f1d
uses: amannn/action-semantic-pull-request@v5
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
Expand All @@ -34,4 +34,4 @@ jobs:
# For work-in-progress PRs you can typically use draft pull requests from Github. However, private repositories on the free plan don't have this option and therefore this action allows you to opt-in to using the special '[WIP]' prefix to indicate this state. This will avoid the validation of the PR title and the pull request checks remain pending. Note that a second check will be reported if this is enabled.
#wip: # optional
# When using "Squash and merge" on a PR with only one commit, GitHub will suggest using that commit message instead of the PR title for the merge commit, and it's easy to commit this by mistake. Enable this option to also validate the commit message for one commit PRs.
validateSingleCommit: true # optional
# validateSingleCommit: true # optional
51 changes: 51 additions & 0 deletions .github/workflows/conversation-labels.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
# This workflow will update issues with proper "conversation related" labels. This mean that stat:awaiting-repsonse label will be present after Unity account made comments and stat:reply-needed will be present when user made latest comment

name: Update conversation labels of the issue

# Trigger for the workflow
# This trigger will populate the github.event object
# Details on properties are here: https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=created#issue_comment
on:
issue_comment:
types: [created]

concurrency:
group: ${{ github.workflow }}-${{ github.event.issue.number }}
cancel-in-progress: true

# Define labels here
env:
AWAITING_RESPONSE: stat:awaiting-response
REPLY_NEEDED: stat:reply-needed

jobs:
conversation_labels:
name: Calculate and update conversation labels of the issue
if: ${{ !github.event.issue.pull_request && github.event.issue.state == 'open' }}
runs-on: ubuntu-latest
permissions:
issues: write

steps:
- name: Calculate labels
run: |

if [[ "${{ github.event.comment.author_association }}" == "MEMBER" ]]; then
# Unity member commented - add awaiting-response, remove reply-needed
echo "ADD=${{ env.AWAITING_RESPONSE }}" >> $GITHUB_ENV
echo "REMOVE=${{ env.REPLY_NEEDED }}" >> $GITHUB_ENV
else
# Non-Unity member commented - add reply-needed, remove awaiting-response
echo "ADD=${{ env.REPLY_NEEDED }}" >> $GITHUB_ENV
echo "REMOVE=${{ env.AWAITING_RESPONSE }}" >> $GITHUB_ENV
fi

- name: Update labels
# This runs a command using the github cli: https://cli.github.com/manual/gh_issue_edit
# If $ADD is set, it will add the label, otherwise it will remove the label
# There is no need to check if $ADD or $REMOVE is set, as the command will ignore it if it is empty
run: gh issue edit "$NUMBER" --add-label "$ADD" --remove-label "$REMOVE"
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GH_REPO: ${{ github.repository }}
NUMBER: ${{ github.event.issue.number }}
39 changes: 39 additions & 0 deletions .github/workflows/mark-stale-issue.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
# This workflow utilises an existing implementation (https://github.com/actions/stale) that performs the following actions:
# 1) Adds "stale" label to issues that have "stat:awaiting-response" for more than 30 days meaning that since we don't have enough information we may potentially close such issue
# 2) Closes issues that have been marked as "stale" for more than 30 days

# This affects only Issues but at some point we may also consider rules for PRs

name: Mark or Close Stale Issues

on:
workflow_dispatch:
schedule:
- cron: '0 0 * * *' # Runs daily at midnight

jobs:
stale:
runs-on: ubuntu-latest
permissions:
issues: write

steps:
- uses: actions/stale@v9
with:
# Only mark issues (not PRs) as stale
any-of-labels: 'stat:awaiting-response'
days-before-stale: 30
days-before-close: 30
stale-issue-label: 'Stale'
exempt-issue-labels: 'stat:import,stat:imported'
stale-issue-message: >
This issue has been automatically marked as stale because it has been awaiting
response for over 30 days without any activity.

Please update the issue with any new information or it may be closed in 30 days.
close-issue-message: >
This issue has been automatically closed because it has been stale for 30 days
without any activity. Feel free to reopen if you have new information to add.
# Prevent the action from marking/closing PRs
days-before-pr-stale: -1
days-before-pr-close: -1
40 changes: 40 additions & 0 deletions .github/workflows/remove-labels-on-issue-close.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
# This workflow will remove almost all labels from closed issues beside ones that could be relevant for future tracking like: "port:", "type:", "priority:", "regression" and "stat:imported"

name: Remove labels when issue is closed

on:
issues:
types: [closed] # We want it to run on closed issues

jobs:
remove_labels:
name: Calculate and remove issue labels
if: ${{ !github.event.issue.pull_request }} # This is needed to distinguish from PRs (which we don't want to affect)
runs-on: ubuntu-latest
permissions:
issues: write

steps:
- name: Find labels to remove
id: data
run: |
# Convert labels to array and filter out type: labels
LABELS_TO_REMOVE=($(echo "$EXISTING_LABELS" | jq -r '.[] | select(startswith("type:") or startswith("port:") or startswith("priority:") or . == "regression" or . == "stat:imported" | not)'))

# Only proceed if we have labels to remove
if [ ${#LABELS_TO_REMOVE[@]} -gt 0 ]; then
echo "REMOVE_LABELS=$(IFS=,; echo "${LABELS_TO_REMOVE[*]}")" >> $GITHUB_ENV
echo "HAS_LABELS=true" >> $GITHUB_ENV
else
echo "HAS_LABELS=false" >> $GITHUB_ENV
fi
env:
EXISTING_LABELS: ${{ toJson(github.event.issue.labels.*.name) }}

- name: Remove labels
if: ${{ env.REMOVE_LABELS != '' }}
run: gh issue edit "$NUMBER" --remove-label "$REMOVE_LABELS"
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GH_REPO: ${{ github.repository }}
NUMBER: ${{ github.event.issue.number }}
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,6 @@ upm-ci~
utr
utr.bat
.download
Tools/CI/bin
Tools/CI/obj

Loading