fix: add flag dedicated server override v2.x #3760
Open
+191
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noellie-velez
commented
Oct 29, 2025
com.unity.netcode.gameobjects/Runtime/Transports/UTP/UnityTransport.cs
Outdated
Show resolved
Hide resolved
…override # Conflicts: # com.unity.netcode.gameobjects/Runtime/Transports/UTP/UnityTransport.cs
… fix/v2.x/add-flag-dedicated-server-override
…override # Conflicts: # com.unity.netcode.gameobjects/Documentation~/TableOfContents.md # com.unity.netcode.gameobjects/Documentation~/configuration.md
noellie-velez
commented
Nov 17, 2025
com.unity.netcode.gameobjects/Runtime/Transports/UTP/UnityTransport.cs
Outdated
Show resolved
Hide resolved
…com:Unity-Technologies/com.unity.netcode.gameobjects into fix/v2.x/add-flag-dedicated-server-override
NoelStephensUnity
approved these changes
Nov 17, 2025
Collaborator
NoelStephensUnity
left a comment
NoelStephensUnity
left a comment
There was a problem hiding this comment.
Looks good Noellie!
👍
jabbacakes
approved these changes
Nov 18, 2025
Contributor
jabbacakes
left a comment
jabbacakes
left a comment
There was a problem hiding this comment.
The content is good, suggestions are mostly for consistency/formatting. Tl;dr:
- Command-line arguments needs a hyphen, so added that for all instances
- Headers should be in sentence case (capitalise only the first letter)
- Removed section breaks, we don't use those in the docs generally
- Added note formatting so that it'll render in the package docs properly
com.unity.netcode.gameobjects/Documentation~/command-line-arguments.md
Outdated
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Documentation~/TableOfContents.md
Outdated
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Documentation~/command-line-arguments.md
Outdated
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Documentation~/command-line-arguments.md
Outdated
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Documentation~/command-line-arguments.md
Outdated
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Documentation~/command-line-arguments.md
Outdated
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Documentation~/command-line-arguments.md
Outdated
Show resolved
Hide resolved
com.unity.netcode.gameobjects/Documentation~/command-line-arguments.md
Outdated
Show resolved
Hide resolved
miniwolf
reviewed
Nov 18, 2025
| /// <param name="listenAddress">The address the server is going to listen on.</param> | ||
| public void SetConnectionData(string ipv4Address, ushort port, string listenAddress = null) | ||
| /// <param name="forceOverrideCommandLineArgs">When true, any command line arguments will be ignored.</param> | ||
| public void SetConnectionData(string ipv4Address, ushort port, string listenAddress = null, bool forceOverrideCommandLineArgs = false) |
Collaborator
There was a problem hiding this comment.
This is a breaking change. Example: Precompiled assemblies will fail when querying the old method.
Collaborator
Author
There was a problem hiding this comment.
forceOverrideCommandLineArgs has a default value so when using SetConnectionData method as before (without the added bool) I guess it should not fail.
That said, there is a failure in the API validation vetting job, is it related @NoelStephensUnity?
Co-authored-by: Amy Reeve <[email protected]>
Co-authored-by: Amy Reeve <[email protected]>
Co-authored-by: Amy Reeve <[email protected]>
Co-authored-by: Amy Reeve <[email protected]>
Co-authored-by: Amy Reeve <[email protected]>
Co-authored-by: Amy Reeve <[email protected]>
Co-authored-by: Amy Reeve <[email protected]>
Co-authored-by: Amy Reeve <[email protected]>
Co-authored-by: Amy Reeve <[email protected]>
Co-authored-by: Amy Reeve <[email protected]>
Titles in sentence case, adding a hyphen to `command-line arguments` and styling Co-authored-by: Amy Reeve <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
fix: #3490
Jira ticket
MTTB-1557
Changelog
SetConnectionData.Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
No back port required.