Skip to content

handle null memberuid, refactor #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

handle null memberuid, refactor #149

wants to merge 10 commits into from
+59 −84

Conversation

simonLeary42
Copy link
Collaborator

@simonLeary42 simonLeary42 commented Apr 7, 2025 •
edited
Loading

  • fixed null memberuid edge case in admin check, UnityGroup, UnityOrg
  • renamed UnityGroup::GetLDAPPiGroup() to GetLDAPEntry. Renamed local variables from pi_group to entry. Inside the PI group class, calling a variable pi_group means nothing.
  • renamed UnityOrg::GetLDAPOrgGroup() to GetLDAPEntry. Renamed local variables from org_group to entry. Inside the org group class, calling a variable org_group means nothing.
  • renamed UnityOrg::isInOrg to userExists and changed input data type to match UnityGroup::userExists
  • in both UnityGroup and UnityOrg:
    • move logic from get{Org,Group}Members to get{Org,Group}MemberUIDs, handle null memberuid edge case and make available for userExists
  • added type annotations

@simonLeary42 simonLeary42 mentioned this pull request Apr 7, 2025
Open
@simonLeary42 simonLeary42 mentioned this pull request Apr 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@simonLeary42