Created UnityPerms Class #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sheldor1510
commented
Jul 13, 2023
sheldor1510
commented
- Create UnityPerms Class #88
hakasapl
requested changes
Jul 17, 2023
|
|
||
| $user_role = $this->SQL->getRole($uid, $group); | ||
|
|
||
| if ($this->SQL->hasPerm($user_role, 'unity.admin') || $this->SQL->hasPerm($user_role, 'unity.admin_no_grant')) { |
There was a problem hiding this comment.
unity.admin_no_grant should not be able to grant the admin role, so you need a check here that doesn't return true if admin is the role trying to be granted.
|
|
||
| $user_role = $this->SQL->getRole($uid, $group); | ||
|
|
||
| if ($this->SQL->hasPerm($user_role, 'unity.admin') || $this->SQL->hasPerm($user_role, 'unity.admin_no_grant')) { |
There was a problem hiding this comment.
Same here, admin_no_grant should not be able to revoke admin roles.
| * Checks whether a user is in a group or not | ||
| */ | ||
|
|
||
| public function isInGroup($uid, $group) |
There was a problem hiding this comment.
I would prefer if this method accepted both a string for $group, and the object itself. You can check the type of the variable and act accordingly using gettype() in php.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.