Make sure demo styles do not bleed into UV. #1249
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
crhallberg
commented
Dec 10, 2024
crhallberg
commented
- Scope the CSS to make sure it doesn't affect the UV.
- Remove TailwindCSS artifacts.
…ilwind artifacts.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
demiankatz
requested changes
Dec 11, 2024
Contributor
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
I see problematic button styles here that should have been fixed by #1247. Is it possible that you just need to merge the latest upstream dev branch into this PR?
demiankatz
requested changes
Mar 26, 2025
Contributor
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Looks like this needs conflict resolution when time permits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.