-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use only BFF from UI #94
Conversation
b49e2c6
to
5f0ee2a
Compare
1be374d
to
5231e10
Compare
Commit f674a68 : either rewrite commit message (detail: no "." at the end of the first line) or ideally split in two (needs some git voodoo skills that pay off over time - or a good IDE). |
Yes, that commit looks like a squash gone wrong. Better split it up if the 2 changes are unrelated. This can be done with interactive rebase:
Concerning the commit message quality, there has been quite some progress 🙏. To take it one step further, I would appreciate if we could agree to follow the very common conventions outlined here, i.e.:
|
ff9759f
to
5c532e7
Compare
Yeah, should be fixed now. I think they are related closely enough to be 1 commit (hence the failed squash). |
Update API schema and BFF schema to allow UI to only use BFF for software.
Update API schema and BFF schema to allow UI to only use BFF for rollouts.
Update API schema and BFF schema to allow UI to only use BFF for devices.
Move `updateSoftwareSelection` to BFF, and rename `post` to `post_request` to match other request formats.
Use `router.add_api_route` to create routes for the BFF endpoints which just directly call the API endpoints.
5c532e7
to
19e52f0
Compare
Refactors UI and BFF to not require any use of API from the UI. BFF is basically a copy of API for now (except for the
GET
methods).Also some misc JS fixes, and an added router for uploading firmware. Uploading firmware is now combined into 1 endpoint in both the API and BFF.
Closes #81, Closes #91