Fixed keyword highlighting #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewnitschke
commented
Apr 2, 2024
| { | ||
| "[dart]": { | ||
| "editor.formatOnPaste": true, | ||
| "editor.formatOnSave": true, |
There was a problem hiding this comment.
The existence of this field was causing formatting to get all messed up within the test/highlight/keywords.dart file, causing invalid failures
I figured it would be better, and more project idiomatic, to just git ignore this, and let individual devs decide how they want to configure vscode
matthewnitschke
commented
Apr 2, 2024
| @@ -1,3 +1,5 @@ | |||
| /// <reference types="tree-sitter-cli/dsl" /> | |||
There was a problem hiding this comment.
Just lets us use typing/intellisense within this file
|
Looks good to me! |
matthewnitschke
commented
Apr 2, 2024
|
Thanks for all the additional info, and the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current
highlight.scmqueries were fairly broken for keywords. This PR is the result of re-evaluating the keywords available in dart, and updating/fixing existinghighlight.scmandgrammar.jsimplementations.