Merged
Conversation
19wintersp
commented
Feb 28, 2026
Author
19wintersp
left a comment
There was a problem hiding this comment.
Minor issues worth considering
Author
BenWalker01
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Tracks last received QNH per aircraft. Controller can see the last received QNH and whether it is the latest (via new tag item 451), update to the latest QNH (tag function 551), or reset the tracker (552).
On the code: QNH is tracked by a new singleton class which stores each QNH entry as a combination of QNH value, as the two least-significant ASCII digits of the pressure value, and a serial value, to mark a received pressure as stale if the aerodrome QNH changes to a new value, then changes back. The serial will overflow after about a year of continuous half-hourly updates. It probably would be nicer to use a packed representation for the QNH (eg. a
shortcontaining BCD values) instead of a pair ofchars, but thechars can be copied directly from the METAR and to the tag item string, and thememcpywill probably be optimised to a register copy anyway. The QNH is extracted from the METAR on the assumption that the first occurrence of the stringQin the METAR string precedes the QNH, which is true of any valid METAR under Annex 3 (Qalone does not suffice because of theSQcondition).Will look to test this at some point when I have time to do so