dynamic rules: path-exclude rule fix
#1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hidanio
added
bug
Hidanio
changed the title
path-exclude rule fixpath-exclude rule fix
Because this two different conceptions and we should not mix it. We have different logic for launch dynamic rules and embedded (I know that dynamic rules are called that way in the code and I think it’s wrong). We must forcefully separate this concept |
Danil42Russia
approved these changes
Jul 23, 2024
Hidanio
force-pushed
the
hidanio/exclude_rule_fix
branch
from
90a4fa6 to
11736a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.