Updates to CP #499
Open
Updates to CP #499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmp5VT
commented
Jan 22, 2025
|
This should be ready to merge but does depend on a BTAS update |
…darray into kmp5/feature/CP
This catch was being ignored when cholesky_solve fails
|
@evaleev the BTAS PR is ready to merge so this PR is also ready to merge |
evaleev
reviewed
Jun 11, 2025
src/TiledArray/math/solvers/cp/cp.h
Outdated
| TA_ASSERT(!cp_factors.empty(), | ||
| "CP factor matrices have not been computed)"); | ||
| auto result = cp_factors; | ||
| if(with_lambda){ |
There was a problem hiding this comment.
@kmp5VT you don't seem to have git hooks installed, please see https://valeevgroup.github.io/tiledarray/dox-master/_workflow-_notes.html
There was a problem hiding this comment.
I added git hooks and ran clang-format but I am not sure if it actually did anything
|
@kmp5VT is this ready for re-review? |
|
@evaleev Yes I believe this is ready for review again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump BTAS tag and make a new CP algorithm in TA that computes the decomposition of an order-4 tensor in the THC representation.
TODO