Fix Create Schematic placement, rendering on ships #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Could you just add some comments/javadocs explaining what these mixins do? Thanks |
ewoudje
requested changes
Feb 28, 2024
common/src/main/java/org/valkyrienskies/mod/mixin/mod_compat/create/client/MixinDeployTool.java
Outdated
Show resolved
Hide resolved
6 months is a long time huh
xiewuzhiying
pushed a commit
to xiewuzhiying/Valkyrien-Skies-2
that referenced
this pull request
Aug 28, 2024
* initial ugly schematic mixins * added javadoc descriptions for the mixins * Fix the other operations and clean up 6 months is a long time huh --------- Co-authored-by: ewoudje <[email protected]>
Fripe070
pushed a commit
to Fripe070/Valkyrien-Skies-2
that referenced
this pull request
Dec 15, 2024
* initial ugly schematic mixins * added javadoc descriptions for the mixins * Fix the other operations and clean up 6 months is a long time huh --------- Co-authored-by: ewoudje <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial solution very ugly open to feedback