Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash with Sodium and Litematica #819

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

pama1234
Copy link

fix #818

@CLAassistant
Copy link

CLAassistant commented Apr 18, 2024

CLA assistant check
All committers have signed the CLA.

@Hex4dec
Copy link

Hex4dec commented Apr 18, 2024

You should probably do the client check way earlier, maybe at the start of each render function. And why are you doing the client check through dispatcher? Just do level.isClient?

@ewoudje
Copy link
Contributor

ewoudje commented Apr 22, 2024

You should probably do the client check way earlier, maybe at the start of each render function. And why are you doing the client check through dispatcher? Just do level.isClient?

If you'd have checked the original issue you would have seen that this is because the crash that it fixes is because of a custom world implementation.

Copy link
Contributor

@ewoudje ewoudje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewoudje ewoudje merged commit fcae3be into ValkyrienSkies:1.20.1/main Apr 22, 2024
5 checks passed
@dti131
Copy link

dti131 commented Jan 6, 2025

image
Fix #819 does fix the crashing issue, but it adds another issue (much less severe) where blocks that have animations or other entities (such as the blaze burner and conveyor belt) will be rendered near the player. This can be "fixed" by moving to an area without those blocks, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants