Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling Issue with Proton 3.16-1 #1739

Closed
NeptNutz opened this issue Oct 14, 2018 · 16 comments
Closed

Scaling Issue with Proton 3.16-1 #1739

NeptNutz opened this issue Oct 14, 2018 · 16 comments
Labels
cw Regression Confirmed working on an older version of Proton

Comments

@NeptNutz
Copy link

Compatibility Report

  • Name of the game with compatibility issues: Shadow of the Tomb Raider
  • Steam AppID of the game: 750920

System Information

  • GPU: GTX 660 SC
  • Driver/LLVM version: Nvidia 396.54.09
  • Kernel version: 4.15.0-36-generic
  • Proton version: 3.16-1 Beta

I confirm:

  • [*] that I haven't found an existing compatibility report for this game.
  • [*] that I have checked whether there are updates for my system available.

steam-750920.log

Symptoms

This appears not to be so bad at higher resolutions, but I'm testing at 720p on the lowest-of-the-low settings, including no AA. Whatever type of aliasing, or softening, is present in the display scaling on current Proton (3.7-8 and Beta) goes completely away in 3.16-1 Beta, causing the fonts, etc. to get extremely jagged. There is a definite, visible difference.

@kisak-valve kisak-valve added the Regression Confirmed working on an older version of Proton label Oct 14, 2018
@kisak-valve
Copy link
Member

Also mentioned at #773 (comment).

@NeptNutz
Copy link
Author

Just cross-tested game on a Dell (A10/RX 560) Windows 10 stock box with similar-sized 1920x1080 monitor. Same "lowest" settings at 720p in DX11 confirm that Proton 3.7 is the correct 'look'.

@sputniktr02
Copy link

I can confirm the issue. I am having the same issue with the games that use DXVK (Witcher 3, The Forest, etc). DirectX 9 games seems to be fine though.

@dubigrasu
Copy link

dubigrasu commented Oct 15, 2018

I also confirm this happening on Dishonored demo. Looks like for 3.16-1 an nearest type of filtering is used, while for 3.7 a linear one, very visible on text.

3.7 on the left, 3.16 on the right:

screenshot from 2018-10-15 18-05-04

@aeikum
Copy link
Collaborator

aeikum commented Oct 15, 2018

We do request linear scaling when stretching the framebuffer up to the display, see https://github.com/ValveSoftware/wine/blob/proton_3.16/dlls/winevulkan/vulkan.c#L1911 . Nothing changed here between 3.7 and 3.16. @doitsujin, do you have any ideas why this might be happening?

@aeikum
Copy link
Collaborator

aeikum commented Oct 15, 2018

Ah, wait, if we're building DXVK as a native linux .so, it's probably bypassing our fullscreen hack code entirely. I bet that's our problem.

@doitsujin
Copy link
Collaborator

doitsujin commented Oct 15, 2018

This is a DXVK bug. For some reason it is now responsible for doing the scaling by itself, which is okay, but it doesn't handle the case where the window size differs from the Vulkan swap chain size correctly (previously they were always the same). Should be easy to fix though.

@dubigrasu
Copy link

On the same Proton 3.16-1, I replaced the native dxvk libraries with the latest (dll) files from dxvk 0.90 and the scaling issue doesn't happen.

@aeikum
Copy link
Collaborator

aeikum commented Oct 15, 2018

@dubigrasu Thanks for testing, that fits with the explanation. We're going to have to back out the native DXVK build anyway due to issues with the Steam Runtime (see #1730) so this should be fixed alongside that.

@dubigrasu
Copy link

I'm sorry for the probably off-topic question, but can't be the steam-runtime just updated to avoid similar conflicts?

@aeikum
Copy link
Collaborator

aeikum commented Oct 15, 2018

Yes, but that's a much larger task.

@doitsujin
Copy link
Collaborator

Anyway, doitsujin/dxvk@0d1fa17 should fix this.

@Plagman Plagman added the cw label Oct 15, 2018
@kisak-valve
Copy link
Member

Hello @NeptNutz, @dubigrasu, please retest with Proton 3.16-2.

@kisak-valve kisak-valve added the Need Retest Request to retest an issue with vanilla Proton label Oct 17, 2018
@NeptNutz
Copy link
Author

Looks good! Back to normal. [Tested on Nvidia 396.54.09 and 410.66.]

@dubigrasu
Copy link

Yes, all good here.

@kisak-valve
Copy link
Member

Thanks for retesting, closing.

@kisak-valve kisak-valve removed the Need Retest Request to retest an issue with vanilla Proton label Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cw Regression Confirmed working on an older version of Proton
Projects
None yet
Development

No branches or pull requests

7 participants