Skip to content

Revert "fix: preserve parentheses for same-precedence different operators"#71

Merged
f41gh7 merged 1 commit intomasterfrom
revert-67-fix/preserve-parens-same-precedence-ops
Apr 17, 2026
Merged

Revert "fix: preserve parentheses for same-precedence different operators"#71
f41gh7 merged 1 commit intomasterfrom
revert-67-fix/preserve-parens-same-precedence-ops

Conversation

@f41gh7
Copy link
Copy Markdown
Contributor

@f41gh7 f41gh7 commented Apr 17, 2026

Reverts #67


Summary by cubic

Reverts the change that preserved parentheses for same-precedence different operators, restoring the previous expression formatting. This removes extra parens in printed queries (e.g., 100 * a / b) and simplifies binary-op parentheses logic.

  • Removed associativity-based checks and the extra parameter from needBinaryOpArgParens.
  • Updated tests and example outputs to reflect the original formatting.

Written for commit 67d1cff. Summary will update on new commits.

@f41gh7 f41gh7 merged commit 278b8a2 into master Apr 17, 2026
4 checks passed
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.71%. Comparing base (b60c155) to head (67d1cff).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   89.67%   89.71%   +0.04%     
==========================================
  Files          11       11              
  Lines        3001     2996       -5     
==========================================
- Hits         2691     2688       -3     
+ Misses        211      210       -1     
+ Partials       99       98       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant