Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making Docker setup more user friendly, gtsam version update #1

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

sarika93
Copy link
Member

@sarika93 sarika93 commented Feb 4, 2025

Summary of changes

  • Updating GTSAM version in rosinstall files to use the latest stable version 4.2.
    • Why? On the GTSAM develop branch, API-breaking changes are being introduced as they move towards version 4.3. The means the current rosinstall files produce a number of GTSAM-related build issues.
  • Moving Docker-related files into a docker folder
  • Updating the Dockerfile to:
    • include xvfb as it is needed for Rviz to work properly with Docker,
    • download a EuRoC bag file for demo purposes
    • add ROS setup files to .bashrc since this is likely what a user needs this container to run.
    • use the https rosinstall instead of ssh file to avoid running into permissions issues when setting up docker.
  • Adding a bash script to run an image with necessary X11 setup for using Docker with Rviz.
  • Updating kimera_vio_euroc.rviz file for ease of use:
    • Changing background color to black so that the reference frame labels can be read
    • Changing the default fixed frame to odom. - Was not tested with loop closure enabled, but the default setup has loop closure turned off.
  • Minor README changes.

Testing

For testing the Docker container, you will need to copy the updated install files into your container from your local machine. To do the following:

  1. Copy the Kimera-VIO-ROS/install directory into Kimera-VIO-ROS/docker.
  2. Add the following lines to Kimera-VIO-ROS/docker/Dockerfile to directly below line 21 (after the Kimera-VIO-ROS repository is cloned):
COPY install/kimera_vio_ros_ssh.rosinstall /catkin_ws/src/Kimera-VIO-ROS/install/kimera_vio_ros_ssh.rosinstall
COPY install/kimera_vio_ros_https.rosinstall /catkin_ws/src/Kimera-VIO-ROS/install/kimera_vio_ros_https.rosinstall
  1. To run the ROS wrapper in Docker, follow the instructions in Kimera-VIO-ROS/docker/README.md.

Copy link

@enrique-ramkissoon enrique-ramkissoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments. I've had to deviate from the instructions to get this running on my end.

Copy link

@shiv1994 shiv1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thorough testing with the recommended improvements results in expected operation of Kimera-VIO and makes setup much more friendly.

@sarika93 sarika93 requested review from enrique-ramkissoon and removed request for vpradeep07 March 6, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants