Adding Color namespace and replacing cv::viz references from non-visualizer classes #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…other changes and fixing some bugs wrt Scalar/Vec3b confusion. Tested defaults; working
… this is uncommented in future
foohyfooh
requested changes
Feb 18, 2025
| cv::viz is a heavy component to include as a mandatory dependency for Color | ||
| values only, hence the reason for this inclusion. | ||
| */ | ||
| namespace Color { |
There was a problem hiding this comment.
Optional: Creating a Color class that extends from cv::Scalar might be slightly cleaner by avoiding re-purposing Scalar. Happy to leave it as is though.
shiv1994
reviewed
Feb 27, 2025
shiv1994
reviewed
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Change
ColorUtils.hto theutilsdirectory with a Color namespace that can be referenced instead ofcv::viz.Reason for change
A number of non-visualizer scripts make use of
cv::vizto access it'sColorvalues. However,cv::vizis a heavy dependency to include for that alone.As the visualizer and
cv::vizdependency are being removed easy cross-compiling (see issue here), thesecv::vizreferences must be removed. As having theColorvalues are necessary for several classes (e.g.Mesh, MeshOptimization), a replacement must be added to maintain that functionality.