Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/revert axis pickable #1651

Merged
merged 2 commits into from
Dec 25, 2024
Merged

Fix/revert axis pickable #1651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8607671
Revert "fix: fix the bug of axis pickable"
xuefei1313 Dec 25, 2024
0ac69c3
docs: update changlog of rush
xuefei1313 Dec 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/@visactor/vrender-components/fix-revert-axis-pickable_2024-12-25-03-24.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"comment": "Revert \"fix: fix the bug of axis pickable\"\n\nThis reverts commit 55637a84c01f7af8f4b64ccdfc8cd7215a257c03.\n\n",
"type": "none",
"packageName": "@visactor/vrender-components"
}
],
"packageName": "@visactor/vrender-components",
"email": "[email protected]"
}
1 change: 0 additions & 1 deletion packages/vrender-components/src/axis/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ export abstract class AxisBase<T extends AxisBaseAttributes> extends AbstractCom
this.add(this._innerView);

this._renderInner(this._innerView);
this.setAttribute('pickable', false);

this._bindEvent();
}
Expand Down
Loading