Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use Docker instances of VoltDB for testing. (#29)
* Change the test cases to query Docker for the port Volt is exposed on. Change the ddl to tear down the test Volt schema before setting it up. Change the run script to query Docker for the port Volt is exposed on. * A few subtle changes in here but I think I've captured what you were after. As far as getting a Volt instance setup and ready for testing against: - It now defaults to starting a local Volt instance if it can't find a running Docker instance - If it does find a running docker instance it will use that On the testing side: - You can configure the preferred way to run the tests, but it defaults to using a local instance - You can override this by passing a cli option of -i docker to use docker. (Having the tests automagically search for a usable Volt instance gives me the heebie jeebies a bit... I know I switch between projects a lot and am a bit apprehensive about the tests running against a wrong instance). Hopefully it now supporting both ways (via switches) is a usable compromise? Some extra things... Have begun to add some linting Added nvm - minimum node version already quite out of date Some naming hygiene Run tests and lint from npm - still awkward but getting there * Beginnings of a test to track down the "Trying to read beyond buffer length" error. Can only really guess what is triggering it given the sketchy details but the test case tries to replicate what is described in the #18 issue. (#28) Also contains some experimental promise based wrappers around the call back style fns in VoltClient... plus an eslint config. * A few subtle changes in here but I think I've captured what you were after. As far as getting a Volt instance setup and ready for testing against: - It now defaults to starting a local Volt instance if it can't find a running Docker instance - If it does find a running docker instance it will use that On the testing side: - You can configure the preferred way to run the tests, but it defaults to using a local instance - You can override this by passing a cli option of -i docker to use docker. (Having the tests automagically search for a usable Volt instance gives me the heebie jeebies a bit... I know I switch between projects a lot and am a bit apprehensive about the tests running against a wrong instance). Hopefully it now supporting both ways (via switches) is a usable compromise? Some extra things... Have begun to add some linting Added nvm - minimum node version already quite out of date Some naming hygiene Run tests and lint from npm - still awkward but getting there * Fix: Order of statements in drop ddl Fix: Missing test context in buffer test Fix: Test for Volt docker instance in schema setup script Change: Return default Volt port when no Docker container found running volt
- Loading branch information