Skip to content

Commit

Permalink
Revert onboarding form defaults change and upgrade rjsf (#3726)
Browse files Browse the repository at this point in the history
## Description

WATonomous/infra-config#3707 broke the
onboarding form, where the submit button would work on an empty form,
but cause a JavaScript error. This PR reverts the changes.

This PR also upgrades rjsf to the latest version.


## Checklist
- [x] I have read and understood the [WATcloud
Guidelines](https://cloud.watonomous.ca/docs/community-docs/watcloud/guidelines)
- [x] I have performed a self-review of my code
  • Loading branch information
ben-z authored Jan 22, 2025
1 parent 123381e commit 86e1b1a
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 21 deletions.
5 changes: 0 additions & 5 deletions components/onboarding-form.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -363,11 +363,6 @@ export default function OnboardingForm() {
showRootDescription: false,
showAdvancedFields,
}}
experimental_defaultFormStateBehavior={{
// Only populate required default values. This prevents the form from unnecessarily adding default values to fields.
// Docs: https://rjsf-team.github.io/react-jsonschema-form/docs/api-reference/form-props/#emptyobjectfields
emptyObjectFields: 'populateRequiredDefaults',
}}
>
<div className="mt-8 space-x-4">
<Button type="submit">Submit</Button>
Expand Down
30 changes: 15 additions & 15 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion scripts/validate-external-links.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@
WHITELISTED_PREFIXES = [
"https://github.com/WATonomous/infra-config",
"https://github.com/WATonomous/infra-notes",
"https://jira.watonomous.ca"
"https://jira.watonomous.ca",
# FIXME: ceph.io is down and blocking PRs. This is a temporary workaround
# Discussion here: https://discord.com/channels/478659303167885314/1331445846121644133
"https://ceph.io",
]

# These are the URL schemes that are treated as links (internal and external)
Expand Down

0 comments on commit 86e1b1a

Please sign in to comment.