Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jf/linear solve3 again #177

Merged
merged 7 commits into from
Feb 17, 2025
Merged

Jf/linear solve3 again #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7d709dd
Allow for linearsolve 3, disable aqua test for persistent tasks on 1.10
j-fu Feb 12, 2025
75250ca
remove temporary line from runtests
j-fu Feb 12, 2025
470b1bb
fix code quality
j-fu Feb 12, 2025
400c0ad
Merge branch 'master' into jf/LinearSolve3Again
j-fu Feb 16, 2025
9f94b64
relax tolerance in test_formfactors
j-fu Feb 16, 2025
b77752f
format
j-fu Feb 16, 2025
e13cf9f
bump minor version
j-fu Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "VoronoiFVM"
uuid = "82b139dc-5afc-11e9-35da-9b9bdfd336f3"
authors = ["Jürgen Fuhrmann <[email protected]>", "Patrick Jaap", "Daniel Runge", "Dilara Abdel", "Jan Weidner", "Alexander Seiler", "Patricio Farrell", "Matthias Liero"]
version = "2.6.3"
version = "2.7.0"

[deps]
BandedMatrices = "aae01518-5342-5314-be14-df237901396f"
Expand Down Expand Up @@ -49,7 +49,7 @@ GridVisualize = "0.5.2,0.6.1,1"
InteractiveUtils = "1.9"
JLD2 = "0.4.29, 0.5"
LinearAlgebra = "1.9"
LinearSolve = "2.36"
LinearSolve = "2.36, 3.3"
Printf = "1.9"
Random = "1.9"
RecursiveArrayTools = "2,3"
Expand Down
7 changes: 6 additions & 1 deletion test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,12 @@ function run_all_tests(; run_notebooks = false, notebooksonly = false)
Aqua.test_stale_deps(VoronoiFVM)
Aqua.test_deps_compat(VoronoiFVM)
Aqua.test_piracies(VoronoiFVM, broken = true)
Aqua.test_persistent_tasks(VoronoiFVM)
if VERSION >= v"1.11.0"
# Avoid running into https://github.com/SciML/LinearSolve.jl/issues/573
Aqua.test_persistent_tasks(VoronoiFVM)
else
@info "skipping Aqua.test_persistent_tasks(VoronoiFVM) on Julia 1.10"
end
end

if isdefined(Docs, :undocumented_names) # >=1.11
Expand Down
4 changes: 2 additions & 2 deletions test/test_formfactors.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ function ttri(; ntest = 100)
cellfactors!(Triangle2D, Cartesian2D, coord2d, cellnodes, 1, npar2d, epar2d)
bfacefactors!(Triangle2D, Cartesian3D, coord3d, cellnodes, 1, npar3d, epar3d)

@test npar3d ≈ npar2d
@test epar3d ≈ epar2d
@test npar3d ≈ npar2d rtol = 1.0e-7
@test epar3d ≈ epar2d rtol = 1.0e-7
end
return nothing
end
Expand Down
Loading