-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scope extensions update to split "origin" and "site" type extensions #109
Conversation
Incomplete changes to scope_extensions-explainer.md
…lainer, leaving "site" extensions to be addressed by a seperate explainer
I expect to add a "Alternatives considered" section at a later time from summaries of past design discussions. The current PR contains the bulk of the update we need to fully represent the simple "origin" type extensions. |
@diekus, @HowardWolosky PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge, just one change that is obvious to link the manifest issue around scope control
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, great update with a nice focus on user/dev scenarios.
We want to split the current explainer into 2 parts. The first covers "origin" type extensions and all the additional information (association file, etc) needed for that. The 2nd part will propose the "site" type extensions and the additional security measures needed to enable that.
This PR edits the existing explainer to cover the first part.