Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope extensions update to split "origin" and "site" type extensions #109

Merged
merged 6 commits into from
Oct 31, 2024

Conversation

LuHuangMSFT
Copy link
Collaborator

@LuHuangMSFT LuHuangMSFT commented Oct 24, 2024

We want to split the current explainer into 2 parts. The first covers "origin" type extensions and all the additional information (association file, etc) needed for that. The 2nd part will propose the "site" type extensions and the additional security measures needed to enable that.

This PR edits the existing explainer to cover the first part.

@LuHuangMSFT LuHuangMSFT self-assigned this Oct 24, 2024
@LuHuangMSFT
Copy link
Collaborator Author

I expect to add a "Alternatives considered" section at a later time from summaries of past design discussions. The current PR contains the bulk of the update we need to fully represent the simple "origin" type extensions.

@LuHuangMSFT LuHuangMSFT requested a review from dmurph October 24, 2024 03:00
@LuHuangMSFT LuHuangMSFT added the scope-extensions https://github.com/WICG/manifest-incubations/blob/gh-pages/scope_extensions-explainer.md label Oct 24, 2024
@LuHuangMSFT
Copy link
Collaborator Author

@diekus, @HowardWolosky PTAL.

Copy link
Collaborator

@dmurph dmurph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge, just one change that is obvious to link the manifest issue around scope control

@LuHuangMSFT LuHuangMSFT requested a review from dmurph October 24, 2024 21:46
Copy link
Collaborator

@dmurph dmurph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

Copy link

@HowardWolosky HowardWolosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, great update with a nice focus on user/dev scenarios.

@LuHuangMSFT LuHuangMSFT merged commit f255162 into gh-pages Oct 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope-extensions https://github.com/WICG/manifest-incubations/blob/gh-pages/scope_extensions-explainer.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants