Clean up and modernize codebase #406

kadamwhite · 2018-12-20T00:26:34Z

It feels premature to migrate to a typed system, but given the prevalence of modern Node environments there's some other improvements that will help improve the maintainability of the codebase, and we have sufficient unit testing to refactor with confidence.

Contained changes:

Use let and const over var
Use arrow functions where appropriate, to better distinguish functions requiring this access
Use spread operator instead of Object.assign and node.extend
Drop support for node v6 (Breaking)
Update routes configuration for WP v5.0.2
Upgrade Webpack to v4 (remove json-loader, add babel-loader)

This primarily affects IE11; modern Node versions should unanimously support Promise. IE11 will be handled later via a babel configuration used in the browser build.

This ends support for Node 6

Babel-loader will bridge the gap between our Node 8-compatible syntax and modern web browsers (as well as less-modern ones like IE 11)

kadamwhite added 6 commits December 19, 2018 18:29

Remove es6-promise in favor of native promise

4926ab5

This primarily affects IE11; modern Node versions should unanimously support Promise. IE11 will be handled later via a babel configuration used in the browser build.

Convert var to let and const throughout library code

66bc136

Convert appropriate functions to arrow function syntax

daa0d85

Finish switching functions to arrows, and remove JSHint comments

0fad255

Remove outdated style guidance in contributors file

9ce9594

Breaking: Convert Object.assign to spread operator

a72f483

This ends support for Node 6

kadamwhite force-pushed the refactor/cleanup-and-modernization branch from 0ad855f to a72f483 Compare December 20, 2018 21:03

kadamwhite added 7 commits December 20, 2018 16:05

Remove Node v6 from test matrix and clarify support in README

16b1184

Upgrade Webpack and remove json-loader

a85e96f

Upgrade Webpack to v4 and add babel-loader

faaadd9

Babel-loader will bridge the gap between our Node 8-compatible syntax and modern web browsers (as well as less-modern ones like IE 11)

Use spread operator instead of node.extend to reduce bundle size

eedfdba

Exclude args objects for non-GET endpoints from simplified route tree

6ea9e34

Add new default routes json object for v5.0.2

90946cf

Update tests to account for new endpoints and methods

922f3ef

kadamwhite force-pushed the refactor/cleanup-and-modernization branch from 97d6279 to 922f3ef Compare December 20, 2018 22:51

kadamwhite merged commit 922f3ef into master Dec 20, 2018

kadamwhite deleted the refactor/cleanup-and-modernization branch December 20, 2018 22:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean up and modernize codebase #406

Clean up and modernize codebase #406

kadamwhite commented Dec 20, 2018 •

edited

Loading

Clean up and modernize codebase #406

Clean up and modernize codebase #406

Conversation

kadamwhite commented Dec 20, 2018 • edited Loading

kadamwhite commented Dec 20, 2018 •

edited

Loading