defensive check on sermons_array#292
Open
tstephen wants to merge 1 commit into
Open
Conversation
mattytap
pushed a commit
to mattytap/Mattytap-Sermons
that referenced
this pull request
May 1, 2026
Guard the import-message cleanup loop against $sermons_array being non-array (false/null from get_option). Without this, foreach emits a warning under PHP 7.x and a fatal under PHP 8.x. Original patch from upstream PR WP-for-Church/Sermon-Manager#292. Adjusted whitespace and brace placement to match WPCS during ingestion; behaviour is identical to the upstream patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes:
Checklist:
Brief description of the proposed change:
Fix for issue 291
Any other info:
Doesn't identify the root cause of the empty array.