-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selectable Treatments and Stages/Elements #119
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
10 tasks
10 tasks
This was
linked to
issues
Dec 31, 2024
10 tasks
3 tasks
shapeseas
approved these changes
Feb 7, 2025
deliberation-researcher-portal
|
Project |
deliberation-researcher-portal
|
Branch Review |
evan-sync
|
Run status |
|
Run duration | 04m 52s |
Commit |
|
Committer | Dan Kim |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
22
|
View all changes introduced in this branch ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes several changes to improve the handling of treatments and stages in Timeline, as well as new Cypress tests to reflect these changes. The most important additions are new state variables, updates to the Cypress tests, and the introduction of a new Dropdown component for selecting different sections of a treatment object (for now, just treatments and stages).
Closes #97, #98, #102, #106, #107.
Support for dynamic selection of different treatments:
selectedTreatmentIndex
andsetSelectedTreatmentIndex
to the app's global context to handle selection of treatments dynamically.selectedTreatmentIndex
instead of hardcoded indices.Cypress test updates:
filterTreatment.cy.ts
file to include tests forreorder.cy.ts
file to use aliases for drag and drop elements and stages instead of chain of commands to (hopefully) make the tests more robust and resist failures.New Dropdown Component:
Dropdown
component inDropdown.tsx
to standardize the dropdown UI elements used for selecting treatments and stages (and in the future, introSequences and possibly templates).Refactored Timeline:
Submodule update:
deliberation-empirica
.Notes
I added some logic for handling introSequences in Timeline that isn't tested. This is mostly there for future work in a separate branch or issue. This PR only focuses on treatments and stages/elements.