Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other answer type #48

Open
markwhiting opened this issue Nov 24, 2021 · 4 comments
Open

Other answer type #48

markwhiting opened this issue Nov 24, 2021 · 4 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@markwhiting
Copy link
Member

Sometimes we need text along with other answer types, I'd like to develop a good way to indicate that in the survey CSV and then render it consistently.

It should work for checkbox and radio style responses (& and | separated lists in response). Perhaps with a way to denote that its this kind of entry like: Yes | No | Other: .*

I think it should have a word associated with it, e.g., "Other", but that should be set by the CSV, not a default, so it could be something else.

@karansampath karansampath linked a pull request Dec 13, 2021 that will close this issue
karansampath added a commit that referenced this issue Jan 18, 2022
@karansampath karansampath removed a link to a pull request Jan 18, 2022
@karansampath karansampath self-assigned this Jan 22, 2022
sumants-dev added a commit that referenced this issue Jan 23, 2022
* Deploy.yml (#59)

Production branch gets deployed.

* Bug fix submission (#61)

https://www.loom.com/share/480d4371ff7a4b11aa5b09e92f3cc1d7

* Update CRT.csv

* Update demographics.csv

* Update survey.pug

* Update survey.pug

* Update README.md

* Update README.md

Co-authored-by: Mark Whiting <[email protected]>

* Update README.md

Co-authored-by: Mark Whiting <[email protected]>

* Update README.md

* Update README.md

* Survey tracking (#65)

* Bug fix submission

https://www.loom.com/share/480d4371ff7a4b11aa5b09e92f3cc1d7

* Authorization for API calls and alias url generation

* Survey Tracking

* req to res.locals.user

* Survey tracking (#66)

* Bug fix submission

https://www.loom.com/share/480d4371ff7a4b11aa5b09e92f3cc1d7

* Authorization for API calls and alias url generation

* Survey Tracking

* req to res.locals.user

* rename to url

* Added alias redirection

* corrected mistakes from merge

* Survey tracking (#67)

* Bug fix submission

https://www.loom.com/share/480d4371ff7a4b11aa5b09e92f3cc1d7

* Authorization for API calls and alias url generation

* Survey Tracking

* req to res.locals.user

* rename to url

* Added alias redirection

* corrected mistakes from merge

* name changes

* Required columns check

* Other option

* Adding required check

* Modify required

* CRT test

* More test

* More

* REI

* Revert and finalize after testing

* testcsv

* Modifying testcsv

* survey false

* modif test

* modif test 2

* Challenge surveys (#68)

* Added New Packages

Uninstalled Nedb, installed svg-capatcha

* captcha added

* Challenge surveys

* Create challenge_test.csv

* Challenge Surveys

* Allowing End Flag

* Captcha math added

* package modif

* Final changes (except #48)

* survey change

* Bump marked from 2.1.3 to 4.0.10 (#72)

Bumps [marked](https://github.com/markedjs/marked) from 2.1.3 to 4.0.10.
- [Release notes](https://github.com/markedjs/marked/releases)
- [Changelog](https://github.com/markedjs/marked/blob/master/.releaserc.json)
- [Commits](markedjs/marked@v2.1.3...v4.0.10)

---
updated-dependencies:
- dependency-name: marked
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump node-fetch from 2.6.1 to 3.1.1 (#73)

Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.1 to 3.1.1.
- [Release notes](https://github.com/node-fetch/node-fetch/releases)
- [Changelog](https://github.com/node-fetch/node-fetch/blob/main/docs/CHANGELOG.md)
- [Commits](node-fetch/node-fetch@v2.6.1...v3.1.1)

---
updated-dependencies:
- dependency-name: node-fetch
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* bug-fix (#75)

Co-authored-by: Karan Sampath <[email protected]>
Co-authored-by: Mark Whiting <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
sumants-dev added a commit that referenced this issue Jan 23, 2022
* Deploy.yml (#59)

Production branch gets deployed.

* Bug fix submission (#61)

https://www.loom.com/share/480d4371ff7a4b11aa5b09e92f3cc1d7

* Update CRT.csv

* Update demographics.csv

* Update survey.pug

* Update survey.pug

* Update README.md

* Update README.md

Co-authored-by: Mark Whiting <[email protected]>

* Update README.md

Co-authored-by: Mark Whiting <[email protected]>

* Update README.md

* Update README.md

* Survey tracking (#65)

* Bug fix submission

https://www.loom.com/share/480d4371ff7a4b11aa5b09e92f3cc1d7

* Authorization for API calls and alias url generation

* Survey Tracking

* req to res.locals.user

* Survey tracking (#66)

* Bug fix submission

https://www.loom.com/share/480d4371ff7a4b11aa5b09e92f3cc1d7

* Authorization for API calls and alias url generation

* Survey Tracking

* req to res.locals.user

* rename to url

* Added alias redirection

* corrected mistakes from merge

* Survey tracking (#67)

* Bug fix submission

https://www.loom.com/share/480d4371ff7a4b11aa5b09e92f3cc1d7

* Authorization for API calls and alias url generation

* Survey Tracking

* req to res.locals.user

* rename to url

* Added alias redirection

* corrected mistakes from merge

* name changes

* Required columns check

* Other option

* Adding required check

* Modify required

* CRT test

* More test

* More

* REI

* Revert and finalize after testing

* testcsv

* Modifying testcsv

* survey false

* modif test

* modif test 2

* Challenge surveys (#68)

* Added New Packages

Uninstalled Nedb, installed svg-capatcha

* captcha added

* Challenge surveys

* Create challenge_test.csv

* Challenge Surveys

* Allowing End Flag

* Captcha math added

* package modif

* Final changes (except #48)

* survey change

* Bump marked from 2.1.3 to 4.0.10 (#72)

Bumps [marked](https://github.com/markedjs/marked) from 2.1.3 to 4.0.10.
- [Release notes](https://github.com/markedjs/marked/releases)
- [Changelog](https://github.com/markedjs/marked/blob/master/.releaserc.json)
- [Commits](markedjs/marked@v2.1.3...v4.0.10)

---
updated-dependencies:
- dependency-name: marked
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump node-fetch from 2.6.1 to 3.1.1 (#73)

Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.1 to 3.1.1.
- [Release notes](https://github.com/node-fetch/node-fetch/releases)
- [Changelog](https://github.com/node-fetch/node-fetch/blob/main/docs/CHANGELOG.md)
- [Commits](node-fetch/node-fetch@v2.6.1...v3.1.1)

---
updated-dependencies:
- dependency-name: node-fetch
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* bug-fix (#75)

* Bug auth rename fix (#77)

* bug-fix

* New node fetch requires string

Co-authored-by: Karan Sampath <[email protected]>
Co-authored-by: Mark Whiting <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@karansampath
Copy link
Member

Show the text field, allowing it to be clicked only when it is finished, and text field required attributes are derived from that of the question

@markwhiting
Copy link
Member Author

@karansampath Is this ready to be closed? (sorry for the delay, I know we talked about it a little while ago, but not sure what the conclusion was)

@karansampath
Copy link
Member

@markwhiting the PR still needs to be looked at the other radio buttons act like checkboxes and the textbox still doesn’t show up), I was unsure how to fix the bugs.

@markwhiting
Copy link
Member Author

Got it, thanks.

@markwhiting markwhiting added the help wanted Extra attention is needed label Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants