-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General fixes for issues #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor things but mostly looks good! Let me know when you want me to take another pass.
Co-authored-by: Mark Whiting <[email protected]>
Co-authored-by: Mark Whiting <[email protected]>
@karansampath — are you still working on #48? Or is this ready for another check? Could you make a short screen capture walking through all the features so we can see them working. |
All issues except #48 are properly working but I'd like a second look at the code on that (has been commented out). I think the rest of the code is ready to go for now and I can finish that on a separate PR. Have attached a loom showing functionality of the rest below: |
@karansampath just checking — is this ready to go or is there another part we are waiting on? |
This is ready, I'll fix #48 in another PR today @markwhiting |
@karansampath Squash and merge, if that is true. |
Yep, all outdated types have been replaced! |
No description provided.