Multipage Surveys

[karansampath]

Working on ensuring that the numbering of questions works properly. The rest of the implementation should be correct.

[markwhiting]

@karansampath looks good overall. I can do a review once you've finalized the numbering?

Also I notice that the failing test (Missing CSRF middleware) is requesting we add back CSRF. @sumants-dev or @karansampath I thought we had left it out because it is now built in to Express, but perhaps we should explicitly put it back?

[sumants-dev]

I removed it because it added some complications to the flow since we weren't using cookies. I added it back. @karansampath If you have question how it works, DM me, I can go into it. Basically, we have generate a new token for each post request.

@karansampath On unrelated note to csurf protection, please look into this.

1. the final page submission doesn't seem to work. On the last page of the survey for both one page and multipage. It just returns to the survey. You need to add this commented part back for the last page submission.

// if (admin) {
  //   res.render("thanks", {
  //     code: JSON.stringify(req.body, null, 2),
  //     admin: admin,
  //   });
  // } else res.redirect("/"); // Needs to be updated to deal with multiple page surveys

2. Add some logic to change the submit on pages to next. You can do this by creating another PUG form for next pages. Or add a conditional in PUG where a passed parameter from server side indicates this is the last page. https://pugjs.org/language/conditionals.html

[markwhiting]

Thanks @sumants-dev and makes sense re CSRF.

[karansampath]

Ah, thanks for pointing out 1, didn't see that and will get that fixed.

On 2, I thought about adding next but realized that since workers aren't going to be able to access previous pages it may be slightly misleading for them. Won't just a submit make it clear that these answers couldn't be changed later on?

[markwhiting]

If you're thinking about how to make it more clear that people can't go back, perhaps we do something like "Submit page x of y"?

[karansampath]

@sumants-dev I'm slightly unsure how to fix the submission issue, it seems my conditionals aren't working and I'm unsure why. Could you please take a quick look at it? Thanks!

Have fixed the other issues.

[sumants-dev]

You forgot to pipe the variables of check and final in survey.pug. From my testing it was fixed. Check on your end also.

[karansampath]

Tested and fixed numbering. The rendering of the survey looks different so let me know if that's okay otherwise I think the PR is ready to merge @markwhiting.

[markwhiting]

Overall looks great. I just think we could have a minor tweak to get the question format more consistent but otherwise seems good to go.

[markwhiting]

👍