Yuxuan - Unhashable value checks and some restructure #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xehu
approved these changes
Mar 2, 2025
There was a problem hiding this comment.
Looks good! I made a few changes:
(1) added in the updated LIWC docs and built the documentation;
(2) changed the hashability check to be more general (test if something is hashable) rather than look for specific unhashable types;
(3) added two checks under tests/ to ensure that the behavior is as expected, including throwing the correct ValueError.
Things seem to pass -- LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
What's this pull request about?