Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove iteration process in feature_select #89

Open
axiomcura opened this issue Oct 19, 2023 · 1 comment
Open

Remove iteration process in feature_select #89

axiomcura opened this issue Oct 19, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@axiomcura
Copy link
Member

axiomcura commented Oct 19, 2023

Looking at this code in feature_select.py
code location here

# iteratively passing normalized data
    for norm_data, feature_file_out in io_files:
        feature_selection(
            normalized_profile=norm_data,
            out_file=feature_file_out,
            config=config_path,
            log_file=log_path,
        )

In addition, the feature_select.smk module also takes in a list of profiles, therefore removing snakemake parallelization here

It would be best to remove the for loop and take advantage of snakemake's parallelization.

@axiomcura axiomcura added the enhancement New feature or request label Oct 19, 2023
@axiomcura axiomcura self-assigned this Oct 19, 2023
@axiomcura
Copy link
Member Author

Update: This is related to #41. Using a single input for the feature_select module is causing issues. Currently, the script requires a list of file paths, which is removes CytoSnake's multiprocessing (handled by Snakemake). However, we want users to have the option to do feature selection across all plates or choose specific features for each plate while maintaining flexibility.

This will be added into the next release project roadmap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant