Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Code Duplication Due To Profiling Design #95

Open
axiomcura opened this issue Nov 8, 2023 · 0 comments
Open

Reduce Code Duplication Due To Profiling Design #95

axiomcura opened this issue Nov 8, 2023 · 0 comments

Comments

@axiomcura
Copy link
Member

          This comment applies to the pattern of this code block across many of the `workflows/scripts` files. Consider adding a utility function which can help perform some of this work to avoid the repetition of these edits. For example, could the benchmark_dir be resolved and a `bin` path created for each of these with a function? Similarly, consider a custom decorator function help run the same workflows with/without `enable_profiling` (to avoid the duplicate calls to, for example, `build_consensus` with differing context).

Originally posted by @d33bs in #90 (comment)

There must be a way on how to make memray api importable in order to reduce the function call .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant