Skip to content

date-format: Add result hashing to prevent DCE #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 13, 2025

Conversation

camillobruni
Copy link
Contributor

Dead code elimination could be used to bypass the date formatting in extreme cases.
Create a simple hash from the result strings to prevent this.

Copy link

netlify bot commented Mar 26, 2025

Deploy Preview for webkit-jetstream-preview failed. Why did it fail? →

Name Link
🔨 Latest commit e3c3525
🔍 Latest deploy log https://app.netlify.com/sites/webkit-jetstream-preview/deploys/67e3f4ce6548f30008fd2761

Copy link

netlify bot commented Mar 26, 2025

Deploy Preview for webkit-jetstream-preview ready!

Name Link
🔨 Latest commit 3051ba4
🔍 Latest deploy log https://app.netlify.com/sites/webkit-jetstream-preview/deploys/67f3a4a66933be000813f2c9
😎 Deploy Preview https://deploy-preview-60--webkit-jetstream-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@camillobruni camillobruni requested a review from kmiller68 April 24, 2025 15:09
Copy link
Contributor

@kmiller68 kmiller68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camillobruni camillobruni merged commit 19a8be2 into WebKit:main May 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants