Fix case sensitivity of folder attribute parsing (\NoSelect, \NoInferiors) #469

CHANGELOG.md

@@ -6,7 +6,7 @@ Updates should follow the [Keep a CHANGELOG](http://keepachangelog.com/) princip
 
 ## [UNRELEASED]
 ### Fixed
-- NaN
+- Fix case sensitivity of Folder attribute parsing (\NoSelect, \NoInferiors) #469 (thanks @smajti1)
 
 ### Added
 - SSL stream context options added #238 #546 (thanks @llemoine)

src/Folder.php

@@ -259,8 +259,8 @@ protected function getSimpleName($delimiter, $full_name): string|bool {
      * @param $attributes
      */
     protected function parseAttributes($attributes): void {
-        $this->no_inferiors = in_array('\NoInferiors', $attributes);
-        $this->no_select = in_array('\NoSelect', $attributes);
+        $this->no_inferiors = in_array('\NoInferiors', $attributes, true) || \in_array('\Noinferiors', $attributes, true);
+        $this->no_select = in_array('\NoSelect', $attributes, true) || \in_array('\Noselect', $attributes, true);
         $this->marked = in_array('\Marked', $attributes);
         $this->referral = in_array('\Referral', $attributes);
         $this->has_children = in_array('\HasChildren', $attributes);

tests/issues/Issue469Test.php

@@ -0,0 +1,42 @@
+<?php
+
+namespace Tests\issues;
+
+use PHPUnit\Framework\TestCase;
+use Webklex\PHPIMAP\Client;
+use Webklex\PHPIMAP\Folder;
+
+class Issue469Test extends TestCase {
+
+    /**
+     * Test issue #469 - Case sensitive \NoSelect flag check doesn't work for Gmail
+     */
+    public function testIssue(): void {
+		$client = $this->createStub(Client::class);
+		$folder_name = '[Gmail]';
+		$delimiter = '/';
+
+		$attributes = [
+			'\NoInferiors',
+			'\NoSelect',
+		];
+		$folder = new Folder($client, $folder_name, $delimiter, $attributes);
+
+		$attributes_lowercase = [
+			'\Noinferiors',
+			'\Noselect',
+		];
+		$folder_lowercase = new Folder($client, $folder_name, $delimiter, $attributes_lowercase);
+
+		self::assertSame(
+			$folder->no_inferiors,
+			$folder_lowercase->no_inferiors,
+			'The parsed "\NoInferiors" attribute does not match the parsed "\Noinferiors" attribute'
+		);
+		self::assertSame(
+			$folder->no_select,
+			$folder_lowercase->no_select,
+			'The parsed "\NoSelect" attribute does not match the parsed "\Noselect" attribute'
+		);
+	}
+}