Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lts ldy #22

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Lts ldy #22

wants to merge 13 commits into from

Conversation

danyang123
Copy link
Contributor

No description provided.

minBoundingBox.m Outdated
@@ -0,0 +1,63 @@
function bb = minBoundingBox(X)
% compute the minimum bounding box of a set of 2D points
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Download from https://www.mathworks.com/matlabcentral/fileexchange/31126-2d-minimal-bounding-box
Author: Julien Diener, 2011 most updated.

extractFish.m Outdated
else
f_mid=f2_m; D=fish-f2_m;
end
function [f_mid,D] = find_D(fish,f1_m,f2_m,f3_m,f4_m)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find_D seems not meaningful, better to describe the goal of the function a little bit. The same for "f_mid".

@young24
Copy link
Contributor

young24 commented Mar 4, 2019

Please update the part that I commented. The rest is good. @danyang123

@young24
Copy link
Contributor

young24 commented Mar 5, 2019

Nice. Have you tested other videos with the same parameters? @danyang123
Also, please rewrite the readme file to describe the goal and functions of your code. This is important for others to use your code. Thx.

@danyang123
Copy link
Contributor Author

Different videos needs different parameters, I think we should unify the video form and then determine the parameters. @young24

@young24
Copy link
Contributor

young24 commented Mar 5, 2019

Sure. But how to unify the video form? For example, what if the area of fish is larger than the background in some cases? @danyang123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants