Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GPAViewController.swift #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Refactor GPAViewController.swift #1

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d18b80
Refactor GPAViewController.swift
EtherTyper Oct 1, 2017
cff8263
Update GPAViewController.swift
EtherTyper Oct 1, 2017
d5e1965
Update GPAViewController.swift
EtherTyper Oct 1, 2017
55c0e56
Update GPAViewController.swift
EtherTyper Oct 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 20 additions & 33 deletions GPACalculator/GPAViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,9 @@ class GPAViewController: UIViewController {
super.viewWillAppear(animated)
Information.initializeArray()

var totalWestlakeGrades = 0.0;
var totalStandardCredit = 0.0;
var totalStandardGrades = 0.0;

for classAndGrade in Information.classesAndGrades {
totalWestlakeGrades += Double(classAndGrade.grade) * classAndGrade.multiplier
totalStandardGrades += Double(classAndGrade.grade) * classAndGrade.credits
totalStandardCredit += classAndGrade.credits
}
let totalWestlakeGrades = Information.classesAndGrades.map({ Double($0.grade) * $0.multiplier }).reduce(0, { (sum, grade) in sum + grade })
let totalStandardGrades = Information.classesAndGrades.map({ Double($0.grade) * $0.credits }).reduce(0, { (sum, grade) in sum + grade })
let totalStandardCredit = Information.classesAndGrades.map({ $0.credits }).reduce(0, { (sum, credits) in sum + credits })

guard totalStandardCredit != 0, Information.classesAndGrades.count != 0 else {
print("Division by zero in GPA calculation.")
Expand All @@ -60,63 +54,51 @@ class GPAViewController: UIViewController {
var letter: String = ""
switch (standardGPA) {
case 0..<65:
standardGPALabel.textColor = .black
letterGradeLabel.textColor = .black
setColor(.black)
fourPointScale = 0
letter = "E/F"
case 65...66:
standardGPALabel.textColor = .red
letterGradeLabel.textColor = .red
setColor(.red)
fourPointScale = 1
letter = "D"
case 67...69:
standardGPALabel.textColor = .red
letterGradeLabel.textColor = .red
setColor(.red)
fourPointScale = 1.3
letter = "D+"
case 70...72:
standardGPALabel.textColor = .orange
letterGradeLabel.textColor = .orange
setColor(.orange)
fourPointScale = 1.7
letter = "C-"
case 73...76:
standardGPALabel.textColor = .orange
letterGradeLabel.textColor = .orange
setColor(.orange)
fourPointScale = 2.0
letter = "C"
case 77...79:
standardGPALabel.textColor = .orange
letterGradeLabel.textColor = .orange
setColor(.orange)
fourPointScale = 2.3
letter = "C+"
case 80...82:
standardGPALabel.textColor = .yellow
letterGradeLabel.textColor = .yellow
setColor(.yellow)
fourPointScale = 2.7
letter = "B-"
case 83...86:
standardGPALabel.textColor = .yellow
letterGradeLabel.textColor = .yellow
setColor(.yellow)
fourPointScale = 3.0
letter = "B"
case 87...89:
standardGPALabel.textColor = .yellow
letterGradeLabel.textColor = .yellow
setColor(.yellow)
fourPointScale = 3.3
letter = "B+"
case 90...92:
standardGPALabel.textColor = .green
letterGradeLabel.textColor = .green
setColor(.green)
fourPointScale = 3.7
letter = "A-"
case 93...96:
standardGPALabel.textColor = .green
letterGradeLabel.textColor = .green
setColor(.green)
fourPointScale = 4.0
letter = "A"
case 97...100:
standardGPALabel.textColor = .green
letterGradeLabel.textColor = .green
setColor(.green)
fourPointScale = 4.0
letter = "A+"
default:
Expand All @@ -136,6 +118,11 @@ class GPAViewController: UIViewController {
letterGradeLabel.text = "\(letter)"
}

func setColor(_ color: UIColor) {
standardGPALabel.textColor = color
letterGradeLabel.textColor = color
}

override func viewDidLoad() {
super.viewDidLoad()
}
Expand Down