Skip to content

Commit

Permalink
Investigating reasons for poor performance #19
Browse files Browse the repository at this point in the history
Have identified the call to Automaton.minimise() from within the
Automaton.rewrite() method as a *major* time sink.  I'm not sure why
this call is needed, though things definitely do not work without it.
  • Loading branch information
DavePearce committed Nov 27, 2015
1 parent 3fc38a7 commit a72ebd5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions src/wyautl/core/Automaton.java
Original file line number Diff line number Diff line change
Expand Up @@ -494,6 +494,7 @@ public int rewrite(int from, int to, int[] binding) {
}
}

// FIXME: see #19 about this as it needs to be eliminated.
minimise(binding);

return to >= 0 ? binding[to] : to;
Expand Down
2 changes: 1 addition & 1 deletion src/wyrw/core/Reduction.java
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ private State probe(Automaton automaton) {
return new State(automaton, array);
}

public static class Activation extends AbstractActivation {
public final static class Activation extends AbstractActivation {

/**
* The inference rule that this activation will apply.
Expand Down

0 comments on commit a72ebd5

Please sign in to comment.