#99 less arguments?

WiSchLabs · Dec 17, 2016 · eb1960d · eb1960d
1 parent 09d41af
commit eb1960d
Showing 1 changed file with 9 additions and 18 deletions.
diff --git a/core/views/checklist_views.py b/core/views/checklist_views.py
@@ -138,28 +138,19 @@ def post(self, request):
         checklist_item = ChecklistItem.objects.get(checklist__user=request.user, id=checklist_item_id)
 
         if checklist_item:
-            self._handle_checklist_item_update(checklist_item, checklist_item_everyday, checklist_item_home_match,
-                                               checklist_item_matchday_pattern, checklist_item_matchdays)
+            if checklist_item_matchdays:
+                self._update_checklist_item_condition(checklist_item, checklist_item_matchdays, None, False)
+            elif checklist_item_matchday_pattern:
+                self._update_checklist_item_condition(checklist_item, None, checklist_item_matchday_pattern, False)
+            elif checklist_item_home_match:
+                self._update_checklist_item_condition(checklist_item, None, None, True)
+            elif checklist_item_everyday:
+                self._update_checklist_item_condition(checklist_item, None, None, False)
+            checklist_item.save()
             return self.render_json_response({'success': True})
 
         return self.render_json_response({'success': False})
 
-    def _handle_checklist_item_update(self,
-                                      checklist_item,
-                                      checklist_item_everyday,
-                                      checklist_item_home_match,
-                                      checklist_item_matchday_pattern,
-                                      checklist_item_matchdays):
-        if checklist_item_matchdays:
-            self._update_checklist_item_condition(checklist_item, checklist_item_matchdays, None, False)
-        elif checklist_item_matchday_pattern:
-            self._update_checklist_item_condition(checklist_item, None, checklist_item_matchday_pattern, False)
-        elif checklist_item_home_match:
-            self._update_checklist_item_condition(checklist_item, None, None, True)
-        elif checklist_item_everyday:
-            self._update_checklist_item_condition(checklist_item, None, None, False)
-        checklist_item.save()
-
     @staticmethod
     def _update_checklist_item_condition(checklist_item, checklist_item_matchdays, checklist_item_matchday_pattern,
                                          checklist_item_home_match_tomorrow):