Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

Commit

Permalink
Document the current state of the /issues/22
Browse files Browse the repository at this point in the history
  • Loading branch information
MikolajBalcerek committed Aug 2, 2019
1 parent 14fe6ab commit 6fbc8a5
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 10 deletions.
2 changes: 1 addition & 1 deletion dashboard/model/tables_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def get_tables_graph(self, dag_id, execution_date):
dag_progress[table.task_id].end_date,
dag_progress[table.task_id].duration
),
# workaround for table.uses not being able to reference table managed by other DAG
# workaround for this entire method not being able to reference table managed by other DAG in table.uses
# see https://github.com/Wikia/discreETLy/issues/22
parent='main' if table.uses is None or table.uses not in dag_tables.keys() else table.uses
)
Expand Down
2 changes: 0 additions & 2 deletions dashboard/plugins/tables/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ Additionally you may want to provide cadence for how often the table is updated
Update `id` incrementally starting from 1 for each table redeclared with another cadence.
This makes specifying dependency on a particular cadence possible, e.g.: `uses: dbname.frequently_updated.daily`.

If several DAGs use the same table, it needs to be redeclared with each `dag_id` for the table to be supported by
`Tables managed by DAG` view.

See [example file](tables.yaml.template) for more details on the data structure.

Expand Down
7 changes: 0 additions & 7 deletions dashboard/plugins/tables/tables.yaml.template
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,3 @@
dag_id: my_dag
task_id: rollup_table_insert
uses: dbname.frequently_updated_table.daily

# redeclaring popular_raw_table for use with another DAG
- name: popular_raw_table
db: dbname
dag_id: another_dag
task_id: popular_raw_table_sensor

0 comments on commit 6fbc8a5

Please sign in to comment.