forked from wikimedia/mediawiki-extensions-Math
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rel1 43 #7
Open
mmeller-wikia
wants to merge
47
commits into
Wikia:REL1_43
Choose a base branch
from
wikimedia:REL1_43
base: REL1_43
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rel1 43 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I8c94d04c58356afac901de5ed207f110f1b753f7 (cherry picked from commit 6d5ddff)
Change-Id: I94887f6ccb45072180a318776ae96aead8658a18 (cherry picked from commit 6250623)
Change-Id: I017815230c2709ef5933256ba430b5284022637f (cherry picked from commit d68c302)
Change-Id: Ia4fbba3cda087b17587a953a6c01c6fae2fe2b64 (cherry picked from commit 6a46f28)
Currently, information regarding individual LaTeX macros is distributed in various files. This is the first to attempt to collect declarative information regarding tex macros in the texutil.json file. As a proof of concept we start with only the cancel macros. * Adjust texutil tests so that whitespaces are allowed in the payload Change-Id: Iba2dfd5293ad96d8d8e4e2f555c8df9d1ae4d6ca (cherry picked from commit e0acf58)
Render all formulae from Wikipedia and make sure no errors (that end up as wikimedia production errors in logstash) are thrown. Check that no merror tags are generated for the manual page that intends to cover the full spectrum. Currently, some merror tags are generated, which we ignore for this commit. Change-Id: Ifecbd8a1b0afabaa2f818e9241add92a9508bae9 (cherry picked from commit b758ae9)
* in Ie374524dbdf6a753063172fb88e6f60e91b9212e parsing of operatorname was simplified. However, in this process a space after operatorname was introduced. * This adjusts the reference files pointing to the latest release on zendo https://doi.org/10.5281/zenodo.14209690 Bug: T375274 Change-Id: I29a797cdf16088d704c343dd66cc7bfafc519cd9 (cherry picked from commit c89f8ad)
* Transform structure rich information on LaTeX length specifications introduced in I08996129beca9ad852d23f28d7136c982707aea1 into new TexNode class * Adjust rows, i.e., arrays to hold length information * Add tests Bug: T380654 Change-Id: I1aff53c7a5782c1333ed4c16639dfc660802931c (cherry picked from commit 0458ea1)
Change-Id: I7bbf2de7366de12622421dad5549e2faf6904af2
In I94887f6ccb45072180a318776ae96aead8658a18 nullary macros such as $\AA$ were missed. Instead of adding a backslash (cf. patch set 1) we move the functionality to texutil. Bug: T380184 Change-Id: Ie9947b48f03dac03612a5c33bce92bf00df70aa3
In I94887f6ccb45072180a318776ae96aead8658a18 the array environment was missed. Add the array environment in the same as matrix was added. Bug: T380184 Change-Id: I92111829e7e93bc5abd40e01b6c036bbc01ee8a5
In I94887f6ccb45072180a318776ae96aead8658a18 named operators that render as their tex command e.g. \gcd -> gcd, were not taken into account. Remove additional \ in operator names. Bug: T380184 Change-Id: If21cbd091cc9437715b10e3e6e7ffc86d6436010
In I94887f6ccb45072180a318776ae96aead8658a18 some ams macros were not taken into account. Add \ to respective AMS macros. Bug: T380184 Change-Id: I7c59569fb7242f4f6123047003de6cc86ce868ea
In I94887f6ccb45072180a318776ae96aead8658a18 oint macros were not taken into account. Add \ to respective oint macros. Bug: T380184 Change-Id: Iebcf81f4983442ead8665df47d65899a16a6f422
$\left(a\right)'$ produced rendered MathML output that looked like $\left(a'\right)'$. * Remove the deriv (') state when rendering the element within the brackets. Bug: T381102 Change-Id: Id7f192c1f6b7bf4109e735e393e2546e5a39efd7
The Extension:Popup preview was only working in SVG mode. Added a new selector for the preview in MathML mode while keeping the old one working. The selector for the preview in MathML works via the href attribute. Bug: T381046 Change-Id: I81b5c3f2eabaf738de231868089ed80f0f19db6b
The previewin MathML mode was always at the left side of the website. Added values for `node.offsetWidth` and `node.offsetHeight`. Values are taken from `node.getBoundingClientRect()`. Cleaned up if-clause(node.dataset.title) as it is not needed anymore. In-lined IsValidId funtion as there was only one remaining reference. Bug: T381311 Change-Id: Ied17aaaaf9156e2712ed6c7d6d6f08ecccc12286
The preview for math formula has stopped working since `7a9e8fd6221515b48f45ba29d3f102eb899f1e33` from ticket `T380079` from the Extension:Popup Added the `href` attribute to the Math node. The value must be a complete Uri to a local page with a title. The value is taking from `node.baseURI`. Bug: T381310 Bug: T380079 Change-Id: I70204f2d816b5bef19568758d7256847773b08b3
We recently changed the internal treatment of macros to include the `\` in the macro names. The respective code checked if the macro name had the letter 'o' at position 0. Now, this is position 1. * Check for the entire start of over * Output an error if the macro name does not star with under or over * Remove dead code Bug: T382196 Change-Id: I8eefd41e27319c8dbb05900ef2581ce4d548d4fe
By using parseAsBlock(), each message was wrapped inside a paragraph which is then wrapped inside a label, thus preventing the label's own baseline alignment and whitespace from applying correctly. Screenshot comparison on task. Bug: T382375 Change-Id: Ib8a811e8ecb86faf04651f968e188d05711d46c1 (cherry picked from commit ac4795f)
Change-Id: Ie5d5f5bbe7109d36df533b2d920691550512f512
Change-Id: I4826dce86d53aaf9934268341e4fca56b78b2e59
Change-Id: Ia0b41ab700abf82853765e5338ea69231b92fdfd
Change-Id: Ic8a1d16c0c09656db4597f75f49d5bae0cdcdab4
… default attributes for operators in Literal.php line 97 Change-Id: Ief8c0652ba25ea5aed9782127951b989c4eff819 (cherry picked from commit 6b659ab)
Due to trimming of macro names the macro '\ ' requires special treatment. Render as mtext with a is not always known in XML context, therefore use the numeric representation. Bug: T382215 Change-Id: Ia9de613c10a6db8fba2209e821326407deb618bf (cherry picked from commit 657a33d)
Migrate from BaseMappings to texutil.json Note that MMLutil::uc2xNotation is idempotent and only changes text that starts with '\u'. This method might be removed in the future and inlined in the data. * The maintenance script UpdateTexutil.php was committed mainly for reviewing purposed. Bug: T382215 Change-Id: I4898666ba6cbc14a08f1c03d4ec831cfc98d53ef (cherry picked from commit 302fe6c)
Follows-up I0eda7d4213a5f703ab7. Change-Id: Iab717954a638340973b01b5c660f5cd50a09452c (cherry picked from commit ef81158)
Change-Id: I8e3c4a62d2ce6ec0253c82c971e3bbe754bca663
- use fallback tables for both forms {\bf x} or \mathbf{x} - make setFont call mathFont as the functions currently do almost the same. However, keep them seperated as one might want to have them behave differently in the future. Bug: T382672 Change-Id: I547aa4ff7b73e8a427fb97d51df20e67248740c2 (cherry picked from commit 22690e6)
Ref T382643. (cherry picked from commit 1245cdd) Change-Id: If507827ab6cb046a6cfdd6adfe568e1a6eeb3b73
We recently changed the internal treatment of macros to include the `\` in the macro names. In Ic1c28be2a5669183c3dd5d15577a35a1b5a76971, we ignore misplaced limits; however, only without the leading \. Bug: T382716 Change-Id: I5f85496246501284ff9153e080bc14f87c6704ee
== Background == This follows-up I98eabfbeda2fbef3c (T252362) which replaced an inline "purge" permission check, with a declarative "purge" restriction in 2020. This way MediaWiki knows about it, and thus it becomes effectivey unlisted from Special:SpecialPages, when viewing it as logged-out user. In 2023, with MediaWiki 1.41, the "purge" right was replaced with an implicit grant that both logged-out and logged-in users have, thus making Special:MathStatus listed Special:SpecialPages, and this time world-accessible. == This change == * Make the page explicitly unlisted, instead of using a user right as proxy for this. * Make the page explicitly for logged-in users only, like it was prior to I98eabfbeda2fbef3c, but based on isNamed instead of by proxy of a user right. Bug: T344206 Change-Id: I408d1d71dc8cb3c32ad6bd124726d96b26209a1b (cherry picked from commit 67ad6c0)
Change-Id: I53b755bf668ec46024507a56aff57eda0e716ac0
Also document in MathWikibaseInfo what can be null Bug: T385170 Change-Id: I3eb0c28b2feefcde058c909bb854d8ec5dc70e8f (cherry picked from commit dac8e2c)
Bug: T385269 Change-Id: I2023f7e44e27348895a2aee8b25546fc9ffdacda (cherry picked from commit 5dd7a85)
Change-Id: I3edbd54f20d2b6e21d5abb3eb37a930629db0b23
Change-Id: Id10ef1b1a634b439e978db1ac7033c13aafb83b8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.