Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes an empty MediaAsset column a non-blocking validation. #466

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

holmbergius
Copy link
Contributor

Validation tweak on previous validation changes for this release: this ensure that an empty Encounter.mediaAssetX column does not create a blocking error. Still blocks if there is a value (filename) and it cannot be found.

@holmbergius holmbergius marked this pull request as draft April 12, 2024 05:52
@holmbergius holmbergius self-assigned this Apr 12, 2024
@holmbergius holmbergius requested a review from naknomum April 12, 2024 21:29
@holmbergius holmbergius marked this pull request as ready for review April 12, 2024 21:30
@holmbergius
Copy link
Contributor Author

@goddesswarship Confirmed that this specifically adresses the customer blocker raised.

Copy link
Member

@naknomum naknomum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@holmbergius holmbergius merged commit 194810d into master Apr 13, 2024
2 checks passed
@holmbergius holmbergius deleted the bulk-import-llow-empty-images branch April 13, 2024 14:54
@TanyaStere42 TanyaStere42 added this to the 10.1.0 milestone Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants