Skip to content

Common CSS: avoid false-positive border-style on custom properties #77476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronrobertshaw merged 2 commits into from
May 27, 2026
+63 −10
Merged

Common CSS: avoid false-positive border-style on custom properties #77476

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7963e4
Common CSS: avoid false-positive border-style on custom properties
Kgupta62 Apr 19, 2026
a4cb551
Clean up
aaronrobertshaw May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 63 additions & 10 deletions packages/block-library/src/common.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,38 +125,91 @@
html :where(.has-border-color) {
border-style: solid;
}
html :where([style*="border-color"]) {
// Use ^= and *=; selectors so custom properties like --my-border-color
// don't accidentally match. Only real declarations at the start of
// the style string or after a semicolon should trigger these rules.
html
:where(
[style^="border-color"],
[style*=";border-color"],
[style*="; border-color"]
) {
border-style: solid;
}
html :where([style*="border-top-color"]) {
html
:where(
[style^="border-top-color"],
[style*=";border-top-color"],
[style*="; border-top-color"]
) {
border-top-style: solid;
}
html :where([style*="border-right-color"]) {
html
:where(
[style^="border-right-color"],
[style*=";border-right-color"],
[style*="; border-right-color"]
) {
/*rtl:ignore*/
border-right-style: solid;
}
html :where([style*="border-bottom-color"]) {
html
:where(
[style^="border-bottom-color"],
[style*=";border-bottom-color"],
[style*="; border-bottom-color"]
) {
border-bottom-style: solid;
}
html :where([style*="border-left-color"]) {
html
:where(
[style^="border-left-color"],
[style*=";border-left-color"],
[style*="; border-left-color"]
) {
/*rtl:ignore*/
border-left-style: solid;
}

html :where([style*="border-width"]) {
html
:where(
[style^="border-width"],
[style*=";border-width"],
[style*="; border-width"]
) {
border-style: solid;
}
html :where([style*="border-top-width"]) {
html
:where(
[style^="border-top-width"],
[style*=";border-top-width"],
[style*="; border-top-width"]
) {
border-top-style: solid;
}
html :where([style*="border-right-width"]) {
html
:where(
[style^="border-right-width"],
[style*=";border-right-width"],
[style*="; border-right-width"]
) {
/*rtl:ignore*/
border-right-style: solid;
}
html :where([style*="border-bottom-width"]) {
html
:where(
[style^="border-bottom-width"],
[style*=";border-bottom-width"],
[style*="; border-bottom-width"]
) {
border-bottom-style: solid;
}
html :where([style*="border-left-width"]) {
html
:where(
[style^="border-left-width"],
[style*=";border-left-width"],
[style*="; border-left-width"]
) {
/*rtl:ignore*/
border-left-style: solid;
}
Expand Down
Loading