Editor: restore the behavior of only showing back button focus ring on :focus-visible#80114
Editor: restore the behavior of only showing back button focus ring on :focus-visible#80114fushar wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +39 B (0%) Total Size: 7.69 MB 📦 View Changed
|
|
Flaky tests detected in 6b18e98. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/29100080783
|
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR!
The current behavior is not strictly a bug, as it is based on a design system decision to prioritize the use of :focus over :focus-visible. However, I understand the feedback that it is bothersome to see the focus ring appear every time you move across the screen.
For now, I think we can ship this PR to restore the previous behavior.
What?
In #48472 we only show the focus ring for editor sidebar back button on
:focus-visibleonly. Then #80029 removes that behavior by mistake (sorry!). This PR reintroduces the behavior, but not by reverting as-is and instead proposing a simpler CSS. So in the end we still get a cleaner CSS in the file 😄Testing Instructions
< Pages) doesn't get focused (you don't see focus ring).Use of AI Tools
Used Opus 4.8 to brainstorm solutions.