GH-791 Remove unused context key check

Since we are calling the preselect tasks directly via run now and do not
call the `process()` method in the abstract preselect_task class, the
`get_required_context_keys()` method is not called anymore.

Generally, this was not the best approach because its easy to use a
context key that is not listed in the `get_required_context_keys()`
method, so the actual code and the things defined there might diverge.

A better approach would be to use a class instead of an array for the
$context variable (e.g. preselect_context) and make sure it contains all
required fields as properties.

classes/teststrategy/preselect_task.php

@@ -25,7 +25,6 @@
 namespace local_catquiz\teststrategy;
 
 use local_catquiz\local\result;
-use local_catquiz\local\status;
 
 /**
  * Base class for a pre-select task.
@@ -43,42 +42,12 @@
  * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 abstract class preselect_task {
-
     /**
      *
      * @var array|null $context
      */
     protected ?array $context;
 
-    /**
-     * The next task
-     *
-     * @var callable
-     */
-    protected $nexttask;
-
-    /**
-     * Process test strategy
-     *
-     * @param array $context
-     * @param callable $nexttask
-     *
-     * @return result
-     *
-     */
-    public function process(array &$context, callable $nexttask): result {
-        foreach ($this->get_required_context_keys() as $key) {
-            if (!array_key_exists($key, $context)) {
-                return result::err(status::ERROR_FETCH_NEXT_QUESTION);
-            }
-        }
-
-        $context['lastmiddleware'] = str_replace(__NAMESPACE__ . '\\preselect_task\\', '', get_class($this));
-        $this->context = $context;
-        $this->nexttask = $nexttask;
-        return $this->run($context, $nexttask);
-    }
-
     /**
      * This is the function in which the $context can be modified.
      *
@@ -90,12 +59,4 @@ public function process(array &$context, callable $nexttask): result {
      * @return result
      */
     abstract public function run(array &$context): result;
-
-    /**
-     * If a middleware requires a specific key to be available in the $context
-     * input array, it can be specified here.
-     *
-     * @return array
-     */
-    abstract public function get_required_context_keys(): array;
 }

classes/teststrategy/preselect_task/addscalestandarderror.php

@@ -74,20 +74,4 @@ public function run(array &$context): result {
 
         return result::ok($context);
     }
-
-    /**
-     * Get required context keys.
-     *
-     * @return array
-     *
-     */
-    public function get_required_context_keys(): array {
-        return [
-            'contextid',
-            'questions',
-            'initial_standarderror',
-            'person_ability',
-            'progress',
-        ];
-    }
 }

classes/teststrategy/preselect_task/addscalestandarderror_testing.php

@@ -32,20 +32,6 @@
  * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 final class addscalestandarderror_testing extends addscalestandarderror {
-
-    /**
-     * Returns array of required context keys.
-     *
-     * @return array
-     */
-    public function get_required_context_keys(): array {
-        return [
-            ...parent::get_required_context_keys(),
-            'fake_ancestor_scales',
-            'fake_child_scales',
-        ];
-    }
-
     /**
      * Returns array with ancestor scales.
      *

classes/teststrategy/preselect_task/checkpagereload.php

@@ -62,13 +62,4 @@ public function run(array &$context): result {
 
         return result::ok($this->progress->get_last_question());
     }
-
-    /**
-     * Returns the context key.
-     *
-     * @return array
-     */
-    public function get_required_context_keys(): array {
-        return ['progress'];
-    }
 }

classes/teststrategy/preselect_task/filterbyquestionsperscale.php

@@ -106,18 +106,4 @@ public function run(array &$context): result {
         }
         return result::ok($context);
     }
-
-    /**
-     * Get required context keys.
-     *
-     * @return array
-     *
-     */
-    public function get_required_context_keys(): array {
-        return [
-            'progress',
-            'questionsperscale',
-            'teststrategy',
-        ];
-    }
 }

classes/teststrategy/preselect_task/filterbystandarderror.php

@@ -141,22 +141,6 @@ public function run(array &$context): result {
         return result::ok($context);
     }
 
-    /**
-     * Get required context keys.
-     *
-     * @return array
-     *
-     */
-    public function get_required_context_keys(): array {
-        return [
-            'questions',
-            'progress',
-            'se_max',
-            'progress',
-            'pp_min_inc',
-        ];
-    }
-
     /**
      * Returns the list of scales that should inherit from the given scale.
      *

classes/teststrategy/preselect_task/filterbytestinfo.php

@@ -148,20 +148,4 @@ public function run(array &$context): result {
 
         return result::ok($context);
     }
-
-    /**
-     * Get required context keys.
-     *
-     * @return array
-     *
-     */
-    public function get_required_context_keys(): array {
-        return [
-            'questions',
-            'progress',
-            'se_max',
-            'progress',
-            'pp_min_inc',
-        ];
-    }
 }

classes/teststrategy/preselect_task/firstquestionselector.php

@@ -142,21 +142,6 @@ public function run(array &$context): result {
         return result::ok($context);
     }
 
-    /**
-     * Get required context keys.
-     *
-     * @return array
-     *
-     */
-    public function get_required_context_keys(): array {
-        return [
-            'selectfirstquestion',
-            'questions_ordered_by',
-            'testid',
-            'progress',
-        ];
-    }
-
     /**
      * Returns the median ability of the given person parameters.
      *

classes/teststrategy/preselect_task/firstquestionselector_testing.php

@@ -44,14 +44,4 @@ final class firstquestionselector_testing extends firstquestionselector {
     protected function get_personparams_for_adaptivequiz_test(array $context) {
         return $context['fake_personparams_for_test'];
     }
-
-    /**
-     * Get required context keys.
-     *
-     * @return array
-     *
-     */
-    public function get_required_context_keys(): array {
-        return parent::get_required_context_keys()[] = ['fake_personparams_for_test'];
-    }
 }

classes/teststrategy/preselect_task/fisherinformation.php

@@ -87,19 +87,4 @@ public function get_fisherinformation(\stdClass $question, float $ability): ?flo
         );
         return $fisherinformation;
     }
-
-    /**
-     * Get required context keys
-     *
-     * @return array
-     *
-     */
-    public function get_required_context_keys(): array {
-        return [
-            'installed_models',
-            'person_ability',
-            'questions',
-            'original_questions',
-        ];
-    }
 }

classes/teststrategy/preselect_task/lasttimeplayedpenalty.php

@@ -71,19 +71,6 @@ public function run(array &$context): result {
         return result::ok($context);
     }
 
-    /**
-     * Get required context keys.
-     *
-     * @return array
-     *
-     */
-    public function get_required_context_keys(): array {
-        return [
-            'questions',
-            'penalty_threshold',
-        ];
-    }
-
     /**
      * Calculates the penalty factor for the given question according to the time it was last played.
      *

classes/teststrategy/preselect_task/maximumquestionscheck.php

@@ -54,18 +54,4 @@ public function run(array &$context): result {
 
         return result::ok($context);
     }
-
-    /**
-     * Get required context keys.
-     *
-     * @return array
-     *
-     */
-    public function get_required_context_keys(): array {
-        return [
-            'questionsattempted',
-            'maximumquestions',
-            'progress',
-        ];
-    }
 }

classes/teststrategy/preselect_task/maybe_return_pilot.php

@@ -93,17 +93,4 @@ protected function should_return_pilot(): bool {
         $shouldreturnpilot = $rand <= $this->context['pilot_ratio'];
         return $shouldreturnpilot;
     }
-
-    /**
-     * Get required context keys.
-     *
-     * @return array
-     *
-     */
-    public function get_required_context_keys(): array {
-        return [
-            'pilot_ratio',
-            'questions',
-        ];
-    }
 }

classes/teststrategy/preselect_task/mayberemovescale.php

@@ -72,18 +72,4 @@ public function run(array &$context): result {
 
         return result::ok($context);
     }
-
-    /**
-     * Get required context keys.
-     *
-     * @return array
-     *
-     */
-    public function get_required_context_keys(): array {
-        return [
-            'questions',
-            'max_attempts_per_scale',
-            'progress',
-        ];
-    }
 }

classes/teststrategy/preselect_task/noremainingquestions.php

@@ -55,16 +55,4 @@ public function run(array &$context): result {
 
         return result::ok($context);
     }
-
-    /**
-     * Get required context keys.
-     *
-     * @return array
-     *
-     */
-    public function get_required_context_keys(): array {
-        return [
-            'questions',
-        ];
-    }
 }

classes/teststrategy/preselect_task/numberofgeneralattempts.php

@@ -63,18 +63,6 @@ public function run(array &$context): result {
         return result::ok($context);
     }
 
-    /**
-     * Get required context keys.
-     *
-     * @return array
-     *
-     */
-    public function get_required_context_keys(): array {
-        return [
-            'questions',
-        ];
-    }
-
     /**
      * Can be overwritten in the _testing class to prevent access to the DB.
      * @param mixed $context

classes/teststrategy/preselect_task/numberofgeneralattempts_testing.php

@@ -32,14 +32,6 @@
  * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 final class numberofgeneralattempts_testing extends numberofgeneralattempts {
-    /**
-     * Returns array of required context keys.
-     *
-     * @return array
-     */
-    public function get_required_context_keys(): array {
-        return parent::get_required_context_keys()[] = ['fake_questionattemptcounts'];
-    }
     /**
      * Returns array of questions with attempt scount.
      *

classes/teststrategy/preselect_task/playedincurrentattempt.php

@@ -70,16 +70,4 @@ public function run(array &$context): result {
 
         return result::ok($context);
     }
-
-    /**
-     * Get required context keys.
-     *
-     * @return array
-     *
-     */
-    public function get_required_context_keys(): array {
-        return [
-            'questions',
-        ];
-    }
 }