Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor teststrategies #791

Open
davidszkiba opened this issue Dec 23, 2024 · 1 comment
Open

Refactor teststrategies #791

davidszkiba opened this issue Dec 23, 2024 · 1 comment
Assignees
@davidszkiba
Labels
ALISE

Comments

@davidszkiba
Copy link
Contributor

The organization of the question selection tasks (preselect-tasks) employed by the different test strategies via middlewares makes it unnecessarily complex. It can be made simpler by using template method.
It should be possible to simplify this step-by-step.
davidszkiba added a commit that referenced this issue Dec 23, 2024
@davidszkiba
GH-791 Remove checkitemparams preselect-task
c09238d 
This removes the checkitemparams.php preselect-task middleware and makes it a normal method of the strategy class.
davidszkiba added a commit that referenced this issue Dec 23, 2024
@davidszkiba
GH-791 Remove checkbreak preselect task
0372ad1 
This removes the checkbreak pre-select task middleware and makes it a normal method of the strategy class.
davidszkiba added a commit that referenced this issue Dec 23, 2024
@davidszkiba
GH-791 Add wrappers for more pre-select tasks
16adcf5
davidszkiba added a commit that referenced this issue Jan 10, 2025
@davidszkiba
GH-791 Fix failing behat test
fc9fa05
davidszkiba added a commit that referenced this issue Jan 10, 2025
@davidszkiba
GH-791 Make first question selector and page reload check normal methods
d16e80a
davidszkiba added a commit that referenced this issue Jan 10, 2025
@davidszkiba
GH-791 Make update personability a regular method
8cfedf6
@ralferlebach
Copy link
Contributor

Yes! Yes! Yes! 😍

davidszkiba added a commit that referenced this issue Jan 16, 2025
@davidszkiba
GH-791 Remove checkitemparams preselect-task
12ae28b 
This removes the checkitemparams.php preselect-task middleware and makes it a normal method of the strategy class.
davidszkiba added a commit that referenced this issue Jan 16, 2025
@davidszkiba
GH-791 Remove checkbreak preselect task
02f6855 
This removes the checkbreak pre-select task middleware and makes it a normal method of the strategy class.
davidszkiba added a commit that referenced this issue Jan 16, 2025
@davidszkiba
GH-791 Add wrappers for more pre-select tasks
a6f4a67
davidszkiba added a commit that referenced this issue Jan 16, 2025
@davidszkiba
GH-791 Fix failing behat test
a53da03
davidszkiba added a commit that referenced this issue Jan 16, 2025
@davidszkiba
GH-791 Make first question selector and page reload check normal methods
738a254
davidszkiba added a commit that referenced this issue Jan 16, 2025
@davidszkiba
GH-791 Make update personability a regular method
7699ded
davidszkiba added a commit that referenced this issue Jan 16, 2025
@davidszkiba
GH-791 Remove commented-out code
d5937cb
davidszkiba added a commit that referenced this issue Jan 16, 2025
@davidszkiba
GH-791 Finish removing middleware structure
941b6f6
davidszkiba added a commit that referenced this issue Jan 16, 2025
@davidszkiba
GH-791 Finish removing middleware structure
85e8fc7
davidszkiba added a commit that referenced this issue Jan 16, 2025
@davidszkiba
GH-791 Better use of result pattern
04f613e
davidszkiba added a commit that referenced this issue Jan 17, 2025
@davidszkiba
GH-791 Continue refactoring
2ea8ed8
davidszkiba added a commit that referenced this issue Jan 17, 2025
@davidszkiba
GH-791 Remove unused context key check
d75b60e 
Since we are calling the preselect tasks directly via run now and do not
call the `process()` method in the abstract preselect_task class, the
`get_required_context_keys()` method is not called anymore.

Generally, this was not the best approach because its easy to use a
context key that is not listed in the `get_required_context_keys()`
method, so the actual code and the things defined there might diverge.

A better approach would be to use a class instead of an array for the
$context variable (e.g. preselect_context) and make sure it contains all
required fields as properties.
@davidszkiba davidszkiba mentioned this issue Jan 17, 2025
Merged
davidszkiba added a commit that referenced this issue Jan 17, 2025
@davidszkiba
GH-791 Fix docblocks
48787e4
@davidszkiba davidszkiba self-assigned this Jan 20, 2025
davidszkiba added a commit that referenced this issue Jan 24, 2025
@davidszkiba
GH-791 Remove checkitemparams preselect-task
c3f581a 
This removes the checkitemparams.php preselect-task middleware and makes it a normal method of the strategy class.
davidszkiba added a commit that referenced this issue Jan 24, 2025
@davidszkiba
GH-791 Remove checkbreak preselect task
79b25d6 
This removes the checkbreak pre-select task middleware and makes it a normal method of the strategy class.
davidszkiba added a commit that referenced this issue Jan 24, 2025
@davidszkiba
GH-791 Add wrappers for more pre-select tasks
f409513
davidszkiba added a commit that referenced this issue Jan 24, 2025
@davidszkiba
GH-791 Fix failing behat test
d26b190
davidszkiba added a commit that referenced this issue Jan 24, 2025
@davidszkiba
GH-791 Make first question selector and page reload check normal methods
0cbc49f
davidszkiba added a commit that referenced this issue Jan 24, 2025
@davidszkiba
GH-791 Make update personability a regular method
54f476d
davidszkiba added a commit that referenced this issue Jan 24, 2025
@davidszkiba
GH-791 Remove commented-out code
3e4e80f
davidszkiba added a commit that referenced this issue Jan 24, 2025
@davidszkiba
GH-791 Finish removing middleware structure
de58f1b
davidszkiba added a commit that referenced this issue Jan 24, 2025
@davidszkiba
GH-791 Better use of result pattern
6b5a372
davidszkiba added a commit that referenced this issue Jan 24, 2025
@davidszkiba
GH-791 Continue refactoring
cce80dd
davidszkiba added a commit that referenced this issue Jan 24, 2025
@davidszkiba
GH-791 Remove unused context key check
682bbf3 
Since we are calling the preselect tasks directly via run now and do not
call the `process()` method in the abstract preselect_task class, the
`get_required_context_keys()` method is not called anymore.

Generally, this was not the best approach because its easy to use a
context key that is not listed in the `get_required_context_keys()`
method, so the actual code and the things defined there might diverge.

A better approach would be to use a class instead of an array for the
$context variable (e.g. preselect_context) and make sure it contains all
required fields as properties.
davidszkiba added a commit that referenced this issue Jan 24, 2025
@davidszkiba
GH-791 Fix docblocks
f37d354
mona-shakiba pushed a commit that referenced this issue Feb 10, 2025
@davidszkiba @mona-shakiba
GH-791 Remove checkitemparams preselect-task
d935e8f 
This removes the checkitemparams.php preselect-task middleware and makes it a normal method of the strategy class.
mona-shakiba pushed a commit that referenced this issue Feb 10, 2025
@davidszkiba @mona-shakiba
GH-791 Remove checkbreak preselect task
94c2883 
This removes the checkbreak pre-select task middleware and makes it a normal method of the strategy class.
mona-shakiba pushed a commit that referenced this issue Feb 10, 2025
@davidszkiba @mona-shakiba
GH-791 Add wrappers for more pre-select tasks
463c4eb
mona-shakiba pushed a commit that referenced this issue Feb 10, 2025
@davidszkiba @mona-shakiba
GH-791 Fix failing behat test
8071f6f
mona-shakiba pushed a commit that referenced this issue Feb 10, 2025
@davidszkiba @mona-shakiba
GH-791 Make first question selector and page reload check normal methods
2f6ec9b
mona-shakiba pushed a commit that referenced this issue Feb 10, 2025
@davidszkiba @mona-shakiba
GH-791 Make update personability a regular method
95790f4
mona-shakiba pushed a commit that referenced this issue Feb 10, 2025
@davidszkiba @mona-shakiba
GH-791 Remove commented-out code
d25bd9a
mona-shakiba pushed a commit that referenced this issue Feb 10, 2025
@davidszkiba @mona-shakiba
GH-791 Finish removing middleware structure
f34aca8
mona-shakiba pushed a commit that referenced this issue Feb 10, 2025
@davidszkiba @mona-shakiba
GH-791 Better use of result pattern
d3fd88f
mona-shakiba pushed a commit that referenced this issue Feb 10, 2025
@davidszkiba @mona-shakiba
GH-791 Continue refactoring
5136943
mona-shakiba pushed a commit that referenced this issue Feb 10, 2025
@davidszkiba @mona-shakiba
GH-791 Remove unused context key check
08b7e02 
Since we are calling the preselect tasks directly via run now and do not
call the `process()` method in the abstract preselect_task class, the
`get_required_context_keys()` method is not called anymore.

Generally, this was not the best approach because its easy to use a
context key that is not listed in the `get_required_context_keys()`
method, so the actual code and the things defined there might diverge.

A better approach would be to use a class instead of an array for the
$context variable (e.g. preselect_context) and make sure it contains all
required fields as properties.
mona-shakiba pushed a commit that referenced this issue Feb 10, 2025
@davidszkiba @mona-shakiba
GH-791 Fix docblocks
e98b877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidszkiba davidszkiba

Labels
ALISE
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ralferlebach @davidszkiba