Dev david issue 723 #771
Merged
Dev david issue 723 #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
actions succeed only for php 7.4 @davidszkiba |
davidszkiba
force-pushed
the
dev-david-issue-723
branch
6 times, most recently
from
e019157 to
4872749
Compare
This is a stub for the webservice that accepts response data from a client.
For testing, I created a site at URL /local/catquiz/client/submit_responses.php where submitting data can be easily tested. There are now basic plugin settings: - central_host: the address of the central host - central_token: the token used to access the central host - central_scale: The scale that should be synced. For now, this is a basic input field that expects an integer, but this should be changed in the future. There are database tables to store information about send requests and mappings of questions. There is now also a question mapper that calculates a hash from question properties - this way we will be able to map questions based on their properties (text, answers, etc).
This changes the data to be returned and also creates a simple page fetch_parameters.php for testing during development.
Changes local_catquiz_question_hashmap to local_catquiz_qhashmap
This adds a "Sync" button to the scale detail view. It will sync all parameters associated with that scale or any of its subscales from the central instance.
- Only create a new contextid if parameters were synced - Carry-over old itemparameters to the new context and include them in the decision of which model should be the active one. E.g., if we get 3 new models for questionid 1 but already have a different model locally with a higher status, this one should still be set as the active one.
This sets the lowercase name as label. Since we already have a validation step that checks if the name is unique, it should be save to use the lowercase name as label.
- Changed the string of the save button for remote settings config: its more specific AND behat checks for the default save string when doing another test and having two buttons with that string on the same page made it fail. - Remove php unit `resetAfterTest()` after converting a unit test to be a `basic_testcase` - Pass some person params as variables to fix pass-by-reference errors
The host has to be given with a scheme and PARAM_HOST would not allow that. So this is changed to PARAM_TEXT here.
The index is a single number, not an array
When returning parameters via the distribute parameters webservice, include the `guessing` parameter with a default value of 0.0.
The settings to enable/disable syncronization with a central instance and to mark an instance as "central" have been lost during a rebase. This commit is re-adding them.
davidszkiba
force-pushed
the
dev-david-issue-723
branch
from
0287fb5 to
35e9fe2
Compare
The scale synchronization expects scales to have labels. While we already set a label when creating a new scale, this adds an upgrade step that will update existing scales.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #723