Feature: Specify Relative Directory Without Specifying Filename#760
Open
Connor-Russell wants to merge 1 commit into
Open
Feature: Specify Relative Directory Without Specifying Filename#760Connor-Russell wants to merge 1 commit into
Connor-Russell wants to merge 1 commit into
Conversation
… dir sep) in the .obj exporter, without specifying the file name (file name will come from the root obj/col)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request allows users to specify a just a folder to export into, vs having to also provide the filename. If only a folder is provided (determined by the name ending in a / or ), the root collection/root obj name will be appended to the specified folder. For example, if the user enters "../MyFolder/" and the collection name is "Object", the collection will be exporter to "<.blend parent dir>/../MyFolder/Object.obj"
Detailed Changes:
xplane_file.py
Testing:
Unit tests were run on 4.11, with the same pass/fails as the current version of XP2B. No new unit tests were added, however I manually verified the file exports to the correct path when a relative directory is specified, when a filename is specified, and when no name is specified.