Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated build instructions for Ubuntu 22.04+ #5292

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

vlntb
Copy link
Collaborator

@vlntb vlntb commented Feb 17, 2025

High Level Overview of Change

Recent Debian-based distributions (i.e. Ubuntu 22.04+) now restrict direct modifications to the system Python. To use an isolated system-wide install, one should use the pipx tool.

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@vlntb vlntb changed the title updated build instructions for Ubuntu 22.04+ Updated build instructions for Ubuntu 22.04+ Feb 17, 2025
@vlntb vlntb added the Documentation README changes, code comments, etc. label Feb 17, 2025
@vlntb vlntb marked this pull request as ready for review February 17, 2025 15:59
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.9%. Comparing base (43e1d44) to head (aa8c7ef).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5292     +/-   ##
=========================================
- Coverage     77.9%   77.9%   -0.0%     
=========================================
  Files          791     791             
  Lines        68007   68006      -1     
  Branches      8349    8350      +1     
=========================================
- Hits         52963   52959      -4     
- Misses       15044   15047      +3     

see 3 files with indirect coverage changes

Impacted file tree graph

@vlntb vlntb added the Trivial Simple change with minimal effect, or already tested. Only needs one approval. label Feb 17, 2025
@bthomee bthomee requested a review from legleux February 17, 2025 16:10
Copy link
Collaborator

@legleux legleux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable suggestion for adding Conan globally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation README changes, code comments, etc. Trivial Simple change with minimal effect, or already tested. Only needs one approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants