-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JA] MPToken #2925
base: master
Are you sure you want to change the base?
[JA] MPToken #2925
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally looks good although I think you'll want to modify some stuff based on #2955.
@l10n/ja/docs/references/http-websocket-apis/public-api-methods/ledger-methods/ledger_entry.md
Outdated
Show resolved
Hide resolved
@l10n/ja/docs/references/http-websocket-apis/public-api-methods/ledger-methods/ledger_entry.md
Outdated
Show resolved
Hide resolved
@l10n/ja/docs/concepts/tokens/fungible-tokens/multi-purpose-tokens.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text looks good but I noticed two files that are out of place, so they're not displaying the translated version when I build the site in local-dev mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file seems to be in the wrong place, which causes it to not be used.
Current: @l10n/ja/docs/references/protocol/data-types/mptokenissuance.md
Correct: @l10n/ja/docs/references/protocol/ledger-data/ledger-entry-types/mptokenissuance.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same problem as mptokenissuance.md
—this file is in the wrong location (should be under ledger-entry-types/
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No action needed here but keep an eye on #3017.
@@ -8,7 +8,7 @@ status: not_enabled | |||
--- | |||
# Multi-purpose Tokens | |||
|
|||
_(Requires the [MPToken amendment][] {% not-enabled /%})_ | |||
_(Requires the [MPTokensV1 amendment][] {% not-enabled /%})_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch here. 👍
#2908