Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JA] MPToken #2925

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[JA] MPToken #2925

wants to merge 8 commits into from

Conversation

tequdev
Copy link
Contributor

@tequdev tequdev commented Dec 27, 2024

@tequdev tequdev requested a review from mDuo13 December 27, 2024 05:26
@mDuo13 mDuo13 added this to the rippled 2.3.0 milestone Jan 7, 2025
Copy link
Collaborator

@mDuo13 mDuo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks good although I think you'll want to modify some stuff based on #2955.

Copy link
Collaborator

@mDuo13 mDuo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text looks good but I noticed two files that are out of place, so they're not displaying the translated version when I build the site in local-dev mode.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file seems to be in the wrong place, which causes it to not be used.

Current: @l10n/ja/docs/references/protocol/data-types/mptokenissuance.md
Correct: @l10n/ja/docs/references/protocol/ledger-data/ledger-entry-types/mptokenissuance.md

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same problem as mptokenissuance.md—this file is in the wrong location (should be under ledger-entry-types/)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No action needed here but keep an eye on #3017.

@@ -8,7 +8,7 @@ status: not_enabled
---
# Multi-purpose Tokens

_(Requires the [MPToken amendment][] {% not-enabled /%})_
_(Requires the [MPTokensV1 amendment][] {% not-enabled /%})_
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch here. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants