Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced PHP documentation #2959

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EdouardCourty
Copy link

@EdouardCourty EdouardCourty commented Jan 24, 2025

Clarification of the PHP Client Libraries documentation
Added code examples of basic use cases for xrpl-php:

  • Transaction submitting
  • NFT Minting
  • Faucet usage
  • Wallet generation

@@ -16,7 +16,7 @@ labels:

トラストラインとは、XRP Ledgerにおける[トークン](../index.md)を保持するための仕組みを指します。トラストラインは、XRP Ledgerのルールである「不要なトークンを他者に保有させることはできない」という原則を強制するものです。この制限は、XRP Ledgerのユースケースである[コミュニティクレジット](../index.md#コミュニティクレジット)などを実現するために不可欠なものです。

トラストラインは[RippleState](../../references/protocol/ledger-data/ledger-entry-types/ripplestate)オブジェクトとして定義されます。それぞれのトラストラインは、以下のような _双方向_ の関係から成り立っています。
トラストラインは[RippleState](/docs/references/protocol/ledger-data/ledger-entry-types/ripplestate.md)オブジェクトとして定義されます。それぞれのトラストラインは、以下のような _双方向_ の関係から成り立っています。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just fixed in #2954. Can you rebase on the latest master branch to get the change from there?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! ✅

- Fixed a broken link in the Japanese docs
@EdouardCourty EdouardCourty force-pushed the docs/enhance-php-documentation branch from a879b4d to f0681ff Compare January 25, 2025 11:36
@EdouardCourty EdouardCourty requested a review from mDuo13 January 27, 2025 15:55
@EdouardCourty
Copy link
Author

Hi, @mDuo13, it's been quite a few days since your last review, could you take another look at this PR? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants