Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Credential Issuer tutorial #2960

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Credential Issuer tutorial #2960

wants to merge 2 commits into from

Conversation

mDuo13
Copy link
Collaborator

@mDuo13 mDuo13 commented Jan 24, 2025

Adds sample code, in Python, and a code walkthrough explaining how to build a service that issues Credentials (XLS-70) on the XRP Ledger.

Adds a code sample and a code walkthrough explaining how to build a
service that issues Credentials (XLS-70) on the XRP Ledger.
@mDuo13 mDuo13 added new topic Describes a detailed document to be added or expanded in detail python Pull requests that update Python code needs japanese translation PRs with English changes that need to be added/updated in the Japanese translation of the site labels Jan 24, 2025
@mDuo13
Copy link
Collaborator Author

mDuo13 commented Feb 24, 2025

Sharing review feedback from Ross at Ripple:

I was able to take a look at the content, it is quite technical (which i assume is intentional) and the following are some overall comments:

  • It would make sense to a technical audience who has reviewed / familiarised with the credentials (either XRPL specific or even just what they are, what they are for, etc)
  • Overall it made sense to me and wasn't hard to follow (though i know the subject + XRPL pretty well)
  • No missing steps that i could see, though it would be good to cover verification in some way.... I know it is sort of covered in "List Credentials" however it would be good to have a step for third-party verification as it kind of closes the loop on what the point of this is
  • I didn't really following the documents parameter in the Request Credential service at all ... i don't think it goes on chain so i don't understand what does happen to it + my view on the VC functionality is it is only in the credential issuing value-chain after the issuer determines someone should receive the credential.... i don't see publishing requirements to get the credential as part of what XRPL provides etc.

I'll follow up with changes based on this feedback.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@esbuild/[email protected] None 0 11.1 MB evanw
npm/@esbuild/[email protected] None 0 9.57 MB evanw
npm/@esbuild/[email protected] None 0 11.1 MB evanw
npm/@esbuild/[email protected] None 0 9.51 MB evanw
npm/@esbuild/[email protected] None 0 9.92 MB evanw
npm/@esbuild/[email protected] None 0 8.65 MB evanw
npm/@esbuild/[email protected] None 0 9.35 MB evanw
npm/@esbuild/[email protected] None 0 8.85 MB evanw
npm/@esbuild/[email protected] None 0 8.65 MB evanw
npm/@esbuild/[email protected] None 0 8.9 MB evanw
npm/@esbuild/[email protected] None 0 9.11 MB evanw
npm/@esbuild/[email protected] None 0 10.2 MB evanw
npm/@esbuild/[email protected] None 0 8.91 MB evanw
npm/@esbuild/[email protected] None 0 8.85 MB evanw
npm/@esbuild/[email protected] None 0 9.77 MB evanw
npm/@esbuild/[email protected] None 0 9.35 MB evanw
npm/@esbuild/[email protected] None 0 9.33 MB evanw
npm/@esbuild/[email protected] None 0 9.37 MB evanw
npm/@esbuild/[email protected] None 0 9.33 MB evanw
npm/@esbuild/[email protected] None 0 8.76 MB evanw
npm/@esbuild/[email protected] None 0 9.2 MB evanw
npm/@esbuild/[email protected] None 0 9.55 MB evanw
npm/@jridgewell/[email protected] None 0 40 kB jridgewell
npm/@rollup/[email protected] None 0 19 kB shellscape
npm/@rollup/[email protected] None 0 37.7 kB shellscape
npm/@types/[email protected] None 0 25.7 kB types

🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs japanese translation PRs with English changes that need to be added/updated in the Japanese translation of the site new topic Describes a detailed document to be added or expanded in detail python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant