-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MPTs to basic data types and currency formats #3011
Open
DennisDawson
wants to merge
8
commits into
master
Choose a base branch
from
3007_MPTs_are_basic_data_types
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+62
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnxie999
reviewed
Feb 24, 2025
shawnxie999
reviewed
Feb 24, 2025
shawnxie999
reviewed
Feb 24, 2025
shawnxie999
reviewed
Feb 24, 2025
shawnxie999
reviewed
Feb 24, 2025
shawnxie999
reviewed
Feb 24, 2025
Co-authored-by: Shawn Xie <[email protected]>
Co-authored-by: Shawn Xie <[email protected]>
Co-authored-by: Shawn Xie <[email protected]>
Co-authored-by: Shawn Xie <[email protected]>
Co-authored-by: Shawn Xie <[email protected]>
shawnxie999
reviewed
Feb 25, 2025
@@ -129,6 +129,16 @@ XRP is specified as a string containing an integer number of "drops" of XRP, whe | |||
"issuer": "rf1BiGeXwwQoi8Z2ueFYTEXSwuJYfV2Jpn" | |||
} | |||
``` | |||
|
|||
- **MPT** - Use `Amount` to specify the value of an MPT. To specify a value of 13.1 units of an MPT: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should add that it needs an AssetScale of 1
shawnxie999
previously approved these changes
Feb 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit but otherwise looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #3007
Need some clarification on precision (is this handled by AssetScale, or do we envision users setting amounts with up to 15 levels of precision?
ShawnXie999 clarified that yes, precision is handled by AssetScale, purely for the convenience of the issuer/user - the label is not used by the ledger, which only counts the number of MPTs, agnostic to an arbitrary scale for each unit.