Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MPTs to basic data types and currency formats #3011

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

DennisDawson
Copy link
Contributor

@DennisDawson DennisDawson commented Feb 21, 2025

Per #3007

Need some clarification on precision (is this handled by AssetScale, or do we envision users setting amounts with up to 15 levels of precision?

ShawnXie999 clarified that yes, precision is handled by AssetScale, purely for the convenience of the issuer/user - the label is not used by the ledger, which only counts the number of MPTs, agnostic to an arbitrary scale for each unit.

@DennisDawson DennisDawson marked this pull request as ready for review February 24, 2025 19:30
@@ -129,6 +129,16 @@ XRP is specified as a string containing an integer number of "drops" of XRP, whe
"issuer": "rf1BiGeXwwQoi8Z2ueFYTEXSwuJYfV2Jpn"
}
```

- **MPT** - Use `Amount` to specify the value of an MPT. To specify a value of 13.1 units of an MPT:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should add that it needs an AssetScale of 1

shawnxie999
shawnxie999 previously approved these changes Feb 25, 2025
Copy link
Contributor

@shawnxie999 shawnxie999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit but otherwise looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants